Misc updates about C++ for OpenCL and SPIR-V. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnastasiaStulova
force-pushed
the
tooling-22-12
branch
from
4fbaea1 to
1493eac
Compare
This change adds information about C++ for OpenCL 2021 and replaces SPIR -> SPIR-V. With introduction of SPIR-V target in Clang/LLVM we should discourage the use of old SPIR everywhere.
AnastasiaStulova
force-pushed
the
tooling-22-12
branch
from
1493eac to
8f17975
Compare
|
Btw I don't quite get the build failure as it seems to report issues in places unaffected by the changes in this PR. |
svenvh
approved these changes
Dec 5, 2022
bashbaug
approved these changes
Mar 3, 2023
| __Note:__ In clang releases up to 12.0, calling most builtin functions requires the extra flags `-Xclang -finclude-default-header` to be passed to clang. Refer to the release documentation for more details. | ||
| __Note:__ In clang releases: | ||
| - 12.x or earlier, calling most builtin functions requires the extra flags `-Xclang -finclude-default-header` to be passed to clang. | ||
| - 13.x or earlier, target ̀spirv32 ̀ must be replaced by ̀̀spir ̀. |
There was a problem hiding this comment.
Suggested change
| - 13.x or earlier, target ̀spirv32 ̀ must be replaced by ̀̀spir ̀. | |
| - 13.x or earlier, target `spirv32` must be replaced by `spir`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds information about C++ for OpenCL 2021 and replaces SPIR -> SPIR-V. With introduction of SPIR-V target in Clang/LLVM we should discourage the use of old SPIR everywhere.