Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias used incorrectly on SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT in registry file #166

Open
MarkY-LunarG opened this issue Mar 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab

Comments

@MarkY-LunarG
Copy link

I'm writing codegen using the xr.xml and I believe the alias for SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT in the file is defined incorrectly.

Currently it is defined with the alias in the KHR indicating that the correct label to use (the alias) is the MND version when I believe it should be the other way around:

Currently

KHR:

    <extension name="XR_KHR_swapchain_usage_input_attachment_bit" number="166" type="instance" supported="openxr">
...
            <enum extends="XrSwapchainUsageFlagBits"    \ 
                         name="XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_KHR"   \
                         alias="XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_MND" \
                         comment="Specifies that the image may: be used as a input attachment."
              />
...
    </extension>

Monado:

    <extension name="XR_MND_swapchain_usage_input_attachment_bit" number="97" type="instance" supported="openxr" promotedto="XR_KHR_swapchain_usage_input_attachment_bit">
...
            <enum bitpos="7" extends="XrSwapchainUsageFlagBits" \
                          name="XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_MND" \
                          comment="Specifies that the image may: be used as a input attachment."/>
...
    </extension>

Correct?

KHR:

    <extension name="XR_KHR_swapchain_usage_input_attachment_bit" number="166" type="instance" supported="openxr">
...
            <enum extends="XrSwapchainUsageFlagBits"    \
                          name="XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_KHR" \
                          comment="Specifies that the image may: be used as a input attachment."/>
...
    </extension>

Monado:

    <extension name="XR_MND_swapchain_usage_input_attachment_bit" number="97" type="instance" supported="openxr" promotedto="XR_KHR_swapchain_usage_input_attachment_bit">
...
            <enum bitpos="7" extends="XrSwapchainUsageFlagBits" \
                          name="XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_MND" \
                          alias="XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_KHR" \
                          comment="Specifies that the image may: be used as a input attachment."/>
...
    </extension>
@MarkY-LunarG MarkY-LunarG added the bug Something isn't working label Mar 4, 2024
@rpavlik
Copy link
Contributor

rpavlik commented Mar 7, 2024

ah, yes, that's a subtle one but I think you are right. Presumably I didn't fully understand the aliases when we put that in.

@rpavlik-bot rpavlik-bot added the synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab label Mar 7, 2024
@rpavlik-bot
Copy link
Collaborator

An issue (number 2228) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2228 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

@rpavlik rpavlik self-assigned this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab
Projects
None yet
Development

No branches or pull requests

3 participants