Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump hipSYCL version and regenerate filters #796

Open
psalz opened this issue Sep 7, 2023 · 3 comments · May be fixed by #874
Open

Bump hipSYCL version and regenerate filters #796

psalz opened this issue Sep 7, 2023 · 3 comments · May be fixed by #874
Assignees
@psalz

Comments

@psalz
Copy link
Contributor

psalz commented Sep 7, 2023

We haven't updated the hipSYCL version used in CI for over a year (3d8b1cd is from January 2022).

We then should regenerate the CI filters for hipSYCL as well. Although one problem we have here is that presumably most of the tests are compile-time disabled for hipSYCL, and we currently don't have a good way of figuring out which ones we can re-enable...
@psalz psalz self-assigned this Feb 15, 2024
@nilsfriess
Copy link
Contributor

Hi, I'm working on the AdaptiveCpp (aka hipSYCL) project and I'd like to help on this. I actually did some work a while ago to fix some issues that caused tests to not compile/ fail in AdaptiveCpp but never really made an effort to update the AdaptiveCpp/hipSYCL version used in the CTS's CI. I'll try to see if I can regenerate the filters file on a test system and report back to you. Likely some tests will not compile/pass anymore but I think it would still be good to have a recent version in CI that can then be updated more often.

I will also probably open a PR soon-ish to update at least the CMake configuration to the new name.

@psalz
Copy link
Contributor Author

psalz commented Feb 21, 2024

Wait, I'm right now in the process of renaming hipSYCL to AdaptiveCpp everywhere and updating the CI filter! 😅 I'll open a PR (hopefully) within the hour.

@nilsfriess
Copy link
Contributor

I haven't started yet, so all good ;)

@psalz psalz linked a pull request Feb 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psalz psalz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename hipSYCL to AdaptiveCpp, update CI and regenerate filter KhronosGroup/SYCL-CTS
2 participants
@psalz @nilsfriess