Change flip texture coordinates with flip texture #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the texture coordinates. If uv* represents something else other than coordinates, we cannot simply perform 1 - uv*.y on it.
Skylion007
referenced
this pull request
in prefrontalcortex/UnityGLTF
Sep 24, 2020
|
@pfcDorn @marwie we may want to look at this again, we've discussed a couple times if this would make sense. For roundtrips and trying to keep them as lossless as possible I still prefer the UV flip, but not sure in the general case. I don't think it's good to introduce a special option either though (and keep both code paths – I think we want one). By now it encompasses a lot more than what's in this PR; e.g. UV animation and so on need to be handled as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better not to flip the texture coordinates. If uv* represents something else other than coordinates, we cannot simply perform 1 - uv*.y on it.