Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in description of VkCmdBuildAccelerationStructures #2439

Open
PtrMan opened this issue Sep 22, 2024 · 3 comments
Open

Typo in description of VkCmdBuildAccelerationStructures #2439

PtrMan opened this issue Sep 22, 2024 · 3 comments

Comments

@PtrMan
Copy link

PtrMan commented Sep 22, 2024

The spec states

VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-10126
For each pInfos[i], dstAccelerationStructure must have been created with a value of
VkAccelerationStructureCreateInfoKHR::size greater than or equal to either:
◦ the memory size required by the build operation, as returned by
vkGetAccelerationStructureBuildSizesKHR with pBuildInfo = pInfos[i] and with each
element of the pMaxPrimitiveCounts array greater than or equal to the equivalent
ppBuildRangeInfos[i][j].primitiveCount values for j in [0,pInfos[i].geometryCount) or,

[0, doesn't make any sense as an index.

@oddhack
Copy link
Contributor

oddhack commented Sep 22, 2024

The intent is that the condition must be true for each j in the specified range. How are you reading it?

@PtrMan
Copy link
Author

PtrMan commented Oct 7, 2024

maybe it means "for j in range 0 to pInfos[i].geometryCount exclusive or,". Then it's clear how the iteration/enumeration is supposed to happen, if that is the right intention/meaning here.

@oddhack
Copy link
Contributor

oddhack commented Oct 7, 2024

maybe it means "for j in range 0 to pInfos[i].geometryCount exclusive or,". Then it's clear how the iteration/enumeration is supposed to happen, if that is the right intention/meaning here.

This is standard mathematical notation for a half-open interval, commonly used in CS documents (such as the C99 Specification, to pick one of many examples). We're not going to rewrite every interval - or other equation - in the specification purely in words.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants