Refactor codegen scripts to use vulkan_object.py #1665
Conversation
Requires hardcoding a few things to make it work, most notably: * Missing Extension Requires Depends information * Missing aliases for handles On the whole, the codegen outputs *almost* identical files from before, making the refactor not able to introduce issues into the output. The changes that do occur to remove duplicated if statements from aliased handles or for comments and whitespace.
|
CI Vulkan-Loader build queued with queue ID 379810. |
|
CI Vulkan-Loader build queued with queue ID 379827. |
|
Oh foey I didn't mark this as a draft. The incremental & verify options are broken because the codegen creates files in different directories and neither of those options match. Very much wanting to get feedback on the codegen itself. I know the clang-format pass that VVL has is missing, but I didn't feel that it was all that necessary to copy/paste all that stuff over. |
|
CI Vulkan-Loader build # 2927 running. |
|
CI Vulkan-Loader build # 2927 passed. |
| def OutputDispatchTableHelper(self, table_type): | ||
| entries = [] | ||
| table = '' | ||
| out.append('#pragma once\n') |
There was a problem hiding this comment.
any reason to not do a ''' multi-block here so it is only a single append (like https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/main/scripts/generators/api_version_generator.py#L89)
| table = '' | ||
| out.append('#pragma once\n') | ||
| out.append('// *** THIS FILE IS GENERATED - DO NOT EDIT ***\n') | ||
| out.append('// See dispatch_table_helper_generator.py for modifications\n') |
There was a problem hiding this comment.
| out.append('// See dispatch_table_helper_generator.py for modifications\n') | |
| out.append(f'// See {os.path.basename(__file__)} for modifications\n') |
|
|
||
|
|
||
| def convert_to_VK_OBJECT_TYPE(self, str_to_convert): | ||
| return '_'.join(['VK', 'OBJECT', 'TYPE'] + self.split_handle_by_capital_case(str_to_convert)).upper() |
There was a problem hiding this comment.
What is this join for? why not just go
| return '_'.join(['VK', 'OBJECT', 'TYPE'] + self.split_handle_by_capital_case(str_to_convert)).upper() | |
| return 'VK_OBJECT_TYPE' + self.split_handle_by_capital_case(str_to_convert)).upper() |
(same for VK_DEBUG_REPORT_OBJECT_TYPE)
| protos += ' return VK_ERROR_EXTENSION_NOT_PRESENT;\n' | ||
| protos += '}\n\n' | ||
| return protos | ||
| for command in self.vk.commands.values(): |
There was a problem hiding this comment.
if you want to level up your python
| for command in self.vk.commands.values(): | |
| for command in [x for x in self.vk.commands.values() if len(x.extensions) > 0]: |
Requires hardcoding a few things to make it work, most notably:
On the whole, the codegen outputs almost identical files from before, making the refactor not able to introduce issues into the output. The changes that do occur to remove duplicated if statements from aliased handles or for comments and whitespace.