Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vkcubepp: Support protected output #1078

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

vkcubepp: Support protected output #1078

wants to merge 1 commit into from
+157 −7

Conversation

gnoliyil
Copy link
Contributor

This change was originally introduced into Fuchsia's Vulkan-Tools fork in https://fxrev.dev/c/third_party/Vulkan-Tools/+/444614.

If --protected_output command line option is specified, vkcubepp will render to the protected memory.

Bug: https://fxbug.dev/378964821

@ci-tester-lunarg
Copy link

Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

charles-lunarg
charles-lunarg approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gnoliyil
vkcubepp: Support protected output
8fd8c03 
This change was originally introduced into Fuchsia's Vulkan-Tools
fork in https://fxrev.dev/c/third_party/Vulkan-Tools/+/444614.

If `--protected_output` command line option is specified, vkcubepp
will render to the protected memory.

Bug: https://fxbug.dev/378964821
Change-Id: I11c89d3d722236448edd41ca51a03f80d0ba7324
@ci-tester-lunarg
Copy link

Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build queued with queue ID 377419.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1627 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1627 failed.

@gnoliyil
Copy link
Contributor Author

#1079 (vkcubepp: Support Fuchsia) has been merged since last review. I uploaded a new version of this PR to include the Fuchsia-specific manifest files to run the tests in protected mode on Fuchsia. Please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-lunarg charles-lunarg charles-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnoliyil @ci-tester-lunarg @CLAassistant @charles-lunarg