Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different JSON schema versions in KHR extensions #2184

Closed
UX3D-haertl opened this issue Jul 7, 2022 · 1 comment
Closed

Different JSON schema versions in KHR extensions #2184

UX3D-haertl opened this issue Jul 7, 2022 · 1 comment

Comments

@UX3D-haertl
Copy link

The glTF schema uses version 2020-12 while the KHR extensions use version Draft 4.
Would it make sense to update the extensions to the same version?
There are some differences between the schemas:

  • exclusiveMinimum, exclusiveMaximum are boolean in Draft 4, but numbers in newer versions. (This is used in e.g. the light extension)
  • in Draft 4 the required field must contain at least one string
  • Draft 4 only specifies "uri" as value for "format", newer version additionally support "uri-reference"

These are some more changes, but I think the exclusiveMinimum/Maximum rule is the only one where the extensions schemas needed to be changed.

@javagl
Copy link
Contributor

javagl commented Jul 7, 2022

Although the title is the exact opposite, I think this is already tracked in #2049 , so I think it's OK to close this. (Drop me a note if not)

@javagl javagl closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants