Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResearchProject discoveredLetters are sent again on save load. #4

Open
Sn1p3rr3c0n opened this issue Sep 29, 2021 · 0 comments
Open

Comments

@Sn1p3rr3c0n
Copy link

If a Mod adds a Discovered Letter then on each game load that letter will be shown again.

<ResearchProjectDef>
...
<discoveredLetterTitle>Sample Title</discoveredLetterTitle>
<discoveredLetterText>Some Text</discoveredLetterText>
 ...
</ResearchProjectDef>

i believe this is caused by the following line: https://github.com/KiameV/rimworld-modifyresearchtime/blob/master/Source/WorldComp.cs#L85
where FinishProject is called for all already completed research.

public void FinishProject(ResearchProjectDef proj, bool doCompletionDialog = false, Pawn researcher = null)
will display a Letter if discoveredLetterTitle is not empty.

this issue was reported to me by: Dalris Othaine. I'm leaving this report so that you are aware of the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant