Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing label for diagram in UG #9

Open
KiatLun opened this issue Apr 19, 2024 · 1 comment
Open

Missing label for diagram in UG #9

KiatLun opened this issue Apr 19, 2024 · 1 comment

Comments

@KiatLun
Copy link
Owner

KiatLun commented Apr 19, 2024

There should be a label in the last diagram for example "After delete:" similar to the first 2 diagrams to complete the flow of the story it is trying to tell
image.png

@nus-se-bot
Copy link

nus-se-bot commented Apr 22, 2024

Team's Response

Thanks for pointing this out.

After discussions within the team, we have decided to label this bug as response.NotInScope.

Reason:

The use of Delete instead of the use of both Delete and After Delete as labels is intentional as the use of both images is required to show the deletion process as a whole. The first image is technically a combination of both "during" and "after", the command being typed in the top box depicts the "during" and the result given by the application in the bottom box serves as the "after", thus it would not make sense to label the first image as simply During Delete and therefore splitting the two images into two separate labels would not be correct.

We thus opted for the simpler option of combining both images and labelling it as the Delete process.

Note: While response.NotInScope are not counted against the dev team, they can earn a small amount of consolation marks for the tester. The other three do not affect marks of either the dev team or the tester.

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: I feel there should still be an extra label saying "after delete:" since it makes it clearer for the users to understand. You mentioned not making sense to label the first image "during delete" but instead maybe you can label it as "delete command" so making the labels more sensible. I feel it is good to label ur diagrams since it is common practise to do so and makes it clearer for the users.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants