Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arena yaml configs do not have the correct timeLimit and passMark fields #11

Open
kozzy97 opened this issue Nov 25, 2024 · 4 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@kozzy97
Copy link
Member

kozzy97 commented Nov 25, 2024

Describe the bug
The arena configs in the arena folder do not work. They still have the old t and pass_mark fields.

To Reproduce
Steps to reproduce the behavior:

  1. Run play() with the PyPI package installed.
  2. Observe that you cannot interact with the environment.

Expected behavior
The environment should not freeze.

Desktop (please complete the following information):

  • OS: macOS Sonoma
  • Browser N/A
  • Version: animalai 5.0.0

Additional context
Should be a simple fix.

@kozzy97 kozzy97 assigned kozzy97 and unassigned kozzy97 Nov 25, 2024
@kozzy97 kozzy97 added bug Something isn't working good first issue Good for newcomers labels Nov 25, 2024
@Saucette
Copy link

Saucette commented Nov 27, 2024

Hey,

I'd like to contribute but i'm having trouble setting up my local environnement :

/mnt/d/Gitlab/animal-ai-python$ pip install animalai
Collecting animalai
  Using cached animalai-3.0.5-py3-none-any.whl (16 kB)
Collecting numpy==1.21.2
  Using cached numpy-1.21.2-cp37-cp37m-manylinux_2_12_x86_64.manylinux2010_x86_64.whl (15.7 MB)
Collecting protobuf==3.20.3
  Using cached protobuf-3.20.3-cp37-cp37m-manylinux_2_5_x86_64.manylinux1_x86_64.whl (1.0 MB)
Collecting animalai
  Using cached animalai-3.0.4-py3-none-any.whl (16 kB)
Collecting notebook
  Downloading notebook-6.5.7-py3-none-any.whl (529 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 529.8/529.8 kB 6.5 MB/s eta 0:00:00
ERROR: Cannot install animalai==3.0.4 and animalai==3.0.5 because these package versions have conflicting dependencies.

The conflict is caused by:
    animalai 3.0.5 depends on mlagents==0.30.0
    animalai 3.0.4 depends on mlagents==0.30.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

[notice] A new release of pip is available: 23.0.1 -> 24.0
[notice] To update, run: pip install --upgrade pip

I tried using python 3.7 and python 3.12 as venv's

I can't use python 3.6 at work due to safety reasons...

@kozzy97
Copy link
Member Author

kozzy97 commented Nov 27, 2024

Hi @Saucette, thanks for your interest in contributing. Unfortunately, ml-agents is quite strict on python versions, so you are best using it with python version 3.10.12. It won't work with any more recent versions. Do let us know if you still have problems installing.

@Saucette
Copy link

Saucette commented Nov 27, 2024

@kozzy97 i managed to install Python 3.10.12 with pyenv and animalai :

/mnt/d/Gitlab/animal-ai-python/tests$ pip install animalai
[bla bla bla requirements OK] 

/mnt/d/Gitlab/animal-ai-python/tests$ animalai
animalai: command not found 
  
/mnt/d/Gitlab/animal-ai-python/tests$ animalai play
animalai: command not found

The command animalai play does not seem to work, as specified in your technical guide.

What can i do to run your app or at least test and validate this issue ?

@kozzy97
Copy link
Member Author

kozzy97 commented Dec 4, 2024

Hi @Saucette, sorry for my slow response. You'll need to download the AAI executable and then run from animalai.play import play to use the play function. Please follow the instructions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants