Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#82 OSSM still moves while at zero speed in stroke engine #87

Open
MarvFPV opened this issue May 7, 2024 · 2 comments
Open

#82 OSSM still moves while at zero speed in stroke engine #87

MarvFPV opened this issue May 7, 2024 · 2 comments

Comments

@MarvFPV
Copy link

MarvFPV commented May 7, 2024

#82
After running movement inside SE and then turning the speed pot to zero the motor still moves, be it at very slow speed. This behaviour differs from the behaviour inside of simple penetration.

@AJ-Koenig
Copy link
Collaborator

Cannot reproduce, can you please test the latest code and provide steps to reproduce or evidence that this persists?

@DangerousTardigradeAdventure
Copy link
Contributor

I'm able to reproduce this issue. Just bringing the speed up and back down to 0 is enough to cause it for me. This issue is caused by the speed smoothing here

next.speed = 0.3 * next.speedKnob + 0.7 * next.speed;

The value of next.speed will never truly be 0 if the knob is adjusted at all, meaning that the stroker will never be stopped. Flooring it resolved the issue for me.

next.speed = floor(0.3 * next.speedKnob + 0.7 * next.speed);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants