Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan 2.0 not compatible with README instructions #282

Open
leander-dsouza opened this issue Feb 27, 2023 · 3 comments · Fixed by #283
Open

Conan 2.0 not compatible with README instructions #282

leander-dsouza opened this issue Feb 27, 2023 · 3 comments · Fixed by #283
Labels
enhancement New feature or request

Comments

@leander-dsouza
Copy link
Contributor

Description

The build installation section fails to run due to the latest release of Conan 2.0.

Version

ROS distribution: Noetic

Branch and commit you are using: noetic-devel, 6f9a445

Steps to reproduce

The execution of the following code block mentioned in the README causes errors.

conan config set general.revisions_enabled=1
conan profile new default --detect > /dev/null
conan profile update settings.compiler.libcxx=libstdc++11 default

Expected behaviour

The profile creation of conan should be seamless with the latest version as well.

Any other information

A quick fix would be specifying the latest compatible version in the installation of conan with this repository.

sudo python3 -m pip install conan==1.59.0
@felixmaisonneuve
Copy link
Contributor

Hi @leander-dsouza,

Commands changed between conan1.X and conan2.X, so I added the instructions to install conan==1.59.0 like you suggested. If users want/need conan2.X, they can always follow the Conan migration guide.

I opened two identical Pull requests (one for the noetic branch and one for the melodic branch). You are free to comment if you feel something is incorrect.

This issue will be closed when the PRs will be merged

Regards,
Felix

@leander-dsouza
Copy link
Contributor Author

Hello @felixmaisonneuve,

The PRs suffice the Conan issue for now. In the future, probably the README will likely contain commands to ensure conan2.X compatibility.

@felixmaisonneuve felixmaisonneuve added the enhancement New feature or request label Mar 17, 2023
@felixmaisonneuve
Copy link
Contributor

I agree with you. I tag this issue to "enhancement" and I will leave open.
When commands are added to the readme to ensure conan2.X compatibility, we will close this issue

Regards,
Felix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants