Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes with bend radii #91

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

r-barton
Copy link
Collaborator

This is a sample which creates a parameterized pipe bend. However the interior hole is not being respected when revolving the sketch.

See this issue

@r-barton r-barton self-assigned this Sep 20, 2024
@r-barton r-barton linked an issue Sep 20, 2024 that may be closed by this pull request
@r-barton
Copy link
Collaborator Author

This is also related to a discord discussion see this thread

@r-barton
Copy link
Collaborator Author

@jgomez720 @greg-kcio opinions on merging this without a proper hole through the pipe

@greg-kcio
Copy link
Collaborator

@jgomez720 @greg-kcio opinions on merging this without a proper hole through the pipe

The code is clean but I think we should wait to include it until it produces a proper pipe with hole.

@jgomez720
Copy link
Collaborator

jgomez720 commented Sep 20, 2024

Agree with Greg. Someone could export a STEP of this and use shell to create the official pipe, but we are asking for too much on the users end imo

r-barton and others added 18 commits September 23, 2024 14:02
…radii

# Conflicts:
#	screenshots/80-20-rail.png
#	screenshots/a-parametric-bearing-pillow-block.png
#	screenshots/ball-bearing.png
#	screenshots/bracket.png
#	screenshots/brake-caliper.png
#	screenshots/car-wheel-assembly.png
#	screenshots/car-wheel.png
#	screenshots/enclosure.png
#	screenshots/flange-with-patterns.png
#	screenshots/flange-xy.png
#	screenshots/focusrite-scarlett-mounting-bracket.png
#	screenshots/french-press.png
#	screenshots/gear-rack.png
#	screenshots/gear.png
#	screenshots/hex-nut.png
#	screenshots/kitt.png
#	screenshots/lego.png
#	screenshots/lug-nut.png
#	screenshots/mounting-plate.png
#	screenshots/multi-axis-robot.png
#	screenshots/pipe-flange-assembly.png
#	screenshots/pipe.png
#	screenshots/poopy-shoe.png
#	screenshots/router-template-slate.png
#	screenshots/sheet-metal-bracket.png
#	screenshots/socket-head-cap-screw.png
#	screenshots/tire.png
#	screenshots/washer.png
#	screenshots/wheel-rotor.png
#	step/80-20-rail.step
#	step/enclosure.step
#	step/focusrite-scarlett-mounting-bracket.step
#	step/mounting-plate.step
#	step/sheet-metal-bracket.step
…radii

# Conflicts:
#	screenshots/80-20-rail.png
#	screenshots/a-parametric-bearing-pillow-block.png
#	screenshots/ball-bearing.png
#	screenshots/bracket.png
#	screenshots/brake-caliper.png
#	screenshots/car-wheel-assembly.png
#	screenshots/car-wheel.png
#	screenshots/enclosure.png
#	screenshots/flange-with-patterns.png
#	screenshots/flange-xy.png
#	screenshots/focusrite-scarlett-mounting-bracket.png
#	screenshots/french-press.png
#	screenshots/gear-rack.png
#	screenshots/gear.png
#	screenshots/hex-nut.png
#	screenshots/kitt.png
#	screenshots/lego.png
#	screenshots/lug-nut.png
#	screenshots/mounting-plate.png
#	screenshots/multi-axis-robot.png
#	screenshots/pipe-flange-assembly.png
#	screenshots/pipe.png
#	screenshots/poopy-shoe.png
#	screenshots/router-template-slate.png
#	screenshots/sheet-metal-bracket.png
#	screenshots/socket-head-cap-screw.png
#	screenshots/tire.png
#	screenshots/washer.png
#	screenshots/wheel-rotor.png
…radii

# Conflicts:
#	screenshots/80-20-rail.png
#	screenshots/a-parametric-bearing-pillow-block.png
#	screenshots/ball-bearing.png
#	screenshots/bracket.png
#	screenshots/brake-caliper.png
#	screenshots/car-wheel-assembly.png
#	screenshots/car-wheel.png
#	screenshots/enclosure.png
#	screenshots/flange-with-patterns.png
#	screenshots/flange-xy.png
#	screenshots/focusrite-scarlett-mounting-bracket.png
#	screenshots/french-press.png
#	screenshots/gear-rack.png
#	screenshots/gear.png
#	screenshots/hex-nut.png
#	screenshots/kitt.png
#	screenshots/lego.png
#	screenshots/lug-nut.png
#	screenshots/mounting-plate.png
#	screenshots/multi-axis-robot.png
#	screenshots/pipe-flange-assembly.png
#	screenshots/pipe.png
#	screenshots/poopy-shoe.png
#	screenshots/router-template-slate.png
#	screenshots/sheet-metal-bracket.png
#	screenshots/socket-head-cap-screw.png
#	screenshots/tire.png
#	screenshots/washer.png
#	screenshots/wheel-rotor.png
…radii

# Conflicts:
#	screenshots/80-20-rail.png
#	screenshots/a-parametric-bearing-pillow-block.png
#	screenshots/ball-bearing.png
#	screenshots/bracket.png
#	screenshots/brake-caliper.png
#	screenshots/car-wheel-assembly.png
#	screenshots/car-wheel.png
#	screenshots/enclosure.png
#	screenshots/flange-with-patterns.png
#	screenshots/flange-xy.png
#	screenshots/focusrite-scarlett-mounting-bracket.png
#	screenshots/french-press.png
#	screenshots/gear-rack.png
#	screenshots/gear.png
#	screenshots/hex-nut.png
#	screenshots/kitt.png
#	screenshots/lego.png
#	screenshots/lug-nut.png
#	screenshots/mounting-plate.png
#	screenshots/multi-axis-robot.png
#	screenshots/pipe-flange-assembly.png
#	screenshots/pipe.png
#	screenshots/poopy-shoe.png
#	screenshots/router-template-slate.png
#	screenshots/sheet-metal-bracket.png
#	screenshots/socket-head-cap-screw.png
#	screenshots/tire.png
#	screenshots/washer.png
#	screenshots/wheel-rotor.png
…radii

# Conflicts:
#	step/80-20-rail.step
#	step/a-parametric-bearing-pillow-block.step
#	step/ball-bearing.step
#	step/bracket.step
#	step/brake-caliper.step
#	step/car-wheel-assembly.step
#	step/car-wheel.step
#	step/dodecahedron.step
#	step/enclosure.step
#	step/flange-with-patterns.step
#	step/flange-xy.step
#	step/focusrite-scarlett-mounting-bracket.step
#	step/food-service-spatula.step
#	step/french-press.step
#	step/gear-rack.step
#	step/gear.step
#	step/hex-nut.step
#	step/kitt.step
#	step/lego.step
#	step/lug-nut.step
#	step/mounting-plate.step
#	step/multi-axis-robot.step
#	step/pipe-flange-assembly.step
#	step/pipe.step
#	step/poopy-shoe.step
#	step/router-template-cross-bar.step
#	step/router-template-slate.step
#	step/sheet-metal-bracket.step
#	step/socket-head-cap-screw.step
#	step/tire.step
#	step/washer.step
#	step/wheel-rotor.step
…radii

# Conflicts:
#	step/80-20-rail.step
#	step/a-parametric-bearing-pillow-block.step
#	step/ball-bearing.step
#	step/bracket.step
#	step/brake-caliper.step
#	step/car-wheel-assembly.step
#	step/car-wheel.step
#	step/dodecahedron.step
#	step/enclosure.step
#	step/flange-with-patterns.step
#	step/flange-xy.step
#	step/focusrite-scarlett-mounting-bracket.step
#	step/food-service-spatula.step
#	step/french-press.step
#	step/gear-rack.step
#	step/gear.step
#	step/hex-nut.step
#	step/kitt.step
#	step/lego.step
#	step/lug-nut.step
#	step/mounting-plate.step
#	step/multi-axis-robot.step
#	step/pipe-flange-assembly.step
#	step/pipe.step
#	step/poopy-shoe.step
#	step/router-template-cross-bar.step
#	step/router-template-slate.step
#	step/sheet-metal-bracket.step
#	step/socket-head-cap-screw.step
#	step/tire.step
#	step/washer.step
#	step/wheel-rotor.step
…radii

# Conflicts:
#	step/80-20-rail.step
#	step/a-parametric-bearing-pillow-block.step
#	step/ball-bearing.step
#	step/bracket.step
#	step/brake-caliper.step
#	step/car-wheel-assembly.step
#	step/car-wheel.step
#	step/dodecahedron.step
#	step/enclosure.step
#	step/flange-with-patterns.step
#	step/flange-xy.step
#	step/focusrite-scarlett-mounting-bracket.step
#	step/food-service-spatula.step
#	step/french-press.step
#	step/gear-rack.step
#	step/gear.step
#	step/hex-nut.step
#	step/kitt.step
#	step/lego.step
#	step/lug-nut.step
#	step/mounting-plate.step
#	step/multi-axis-robot.step
#	step/pipe-flange-assembly.step
#	step/pipe.step
#	step/poopy-shoe.step
#	step/router-template-cross-bar.step
#	step/router-template-slate.step
#	step/sheet-metal-bracket.step
#	step/socket-head-cap-screw.step
#	step/tire.step
#	step/washer.step
#	step/wheel-rotor.step
…radii

# Conflicts:
#	step/80-20-rail.step
#	step/a-parametric-bearing-pillow-block.step
#	step/ball-bearing.step
#	step/bracket.step
#	step/brake-caliper.step
#	step/car-wheel-assembly.step
#	step/car-wheel.step
#	step/dodecahedron.step
#	step/enclosure.step
#	step/flange-with-patterns.step
#	step/flange-xy.step
#	step/focusrite-scarlett-mounting-bracket.step
#	step/food-service-spatula.step
#	step/french-press.step
#	step/gear-rack.step
#	step/gear.step
#	step/hex-nut.step
#	step/kitt.step
#	step/lego.step
#	step/lug-nut.step
#	step/mounting-plate.step
#	step/multi-axis-robot.step
#	step/pipe-flange-assembly.step
#	step/pipe.step
#	step/poopy-shoe.step
#	step/router-template-cross-bar.step
#	step/router-template-slate.step
#	step/sheet-metal-bracket.step
#	step/socket-head-cap-screw.step
#	step/tire.step
#	step/washer.step
#	step/wheel-rotor.step
…radii

# Conflicts:
#	step/80-20-rail.step
#	step/a-parametric-bearing-pillow-block.step
#	step/ball-bearing.step
#	step/bracket.step
#	step/brake-caliper.step
#	step/car-wheel-assembly.step
#	step/car-wheel.step
#	step/dodecahedron.step
#	step/enclosure.step
#	step/flange-with-patterns.step
#	step/flange-xy.step
#	step/focusrite-scarlett-mounting-bracket.step
#	step/food-service-spatula.step
#	step/french-press.step
#	step/gear-rack.step
#	step/gear.step
#	step/hex-nut.step
#	step/kitt.step
#	step/lego.step
#	step/lug-nut.step
#	step/mounting-plate.step
#	step/multi-axis-robot.step
#	step/pipe-flange-assembly.step
#	step/pipe.step
#	step/poopy-shoe.step
#	step/router-template-cross-bar.step
#	step/router-template-slate.step
#	step/sheet-metal-bracket.step
#	step/socket-head-cap-screw.step
#	step/tire.step
#	step/washer.step
#	step/wheel-rotor.step
github-actions bot and others added 5 commits November 19, 2024 16:40
…radii

# Conflicts:
#	step/80-20-rail.step
#	step/a-parametric-bearing-pillow-block.step
#	step/ball-bearing.step
#	step/bracket.step
#	step/brake-caliper.step
#	step/car-wheel-assembly.step
#	step/car-wheel.step
#	step/dodecahedron.step
#	step/enclosure.step
#	step/flange-with-patterns.step
#	step/flange-xy.step
#	step/focusrite-scarlett-mounting-bracket.step
#	step/food-service-spatula.step
#	step/french-press.step
#	step/gear-rack.step
#	step/gear.step
#	step/hex-nut.step
#	step/kitt.step
#	step/lego.step
#	step/lug-nut.step
#	step/mounting-plate.step
#	step/multi-axis-robot.step
#	step/pipe-flange-assembly.step
#	step/pipe.step
#	step/poopy-shoe.step
#	step/router-template-cross-bar.step
#	step/router-template-slate.step
#	step/sheet-metal-bracket.step
#	step/socket-head-cap-screw.step
#	step/tire.step
#	step/washer.step
#	step/wheel-rotor.step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example with pipes at different bend radii
3 participants