Refactor Fillet Logic to Combine Multiple Tags Within the Same Fillet…

… Expression (#4058) * combine tags + tests * delete getFilletTag function * fix playwright test * make eslint happy * delete missed 'const' * delete const rev2
KittyCAD · Oct 3, 2024 · 46d335f · 46d335f
1 parent c84c0b0
commit 46d335f
Show file tree

Hide file tree

Showing 4 changed files with 202 additions and 433 deletions.
diff --git a/e2e/playwright/command-bar-tests.spec.ts b/e2e/playwright/command-bar-tests.spec.ts
@@ -80,9 +80,11 @@ extrude001 = extrude(-10, sketch001)`
     await page.waitForTimeout(100)
     await page.getByRole('button', { name: 'Fillet' }).click()
     await page.waitForTimeout(100)
-    await page.keyboard.press('Enter')
+    await page.keyboard.press('Enter') // skip selection
     await page.waitForTimeout(100)
-    await page.keyboard.press('Enter')
+    await page.keyboard.press('Enter') // accept default radius
+    await page.waitForTimeout(100)
+    await page.keyboard.press('Enter') // submit
     await page.waitForTimeout(100)
     await expect(page.locator('.cm-activeLine')).toContainText(
       `fillet({ radius: ${KCL_DEFAULT_LENGTH}, tags: [seg01] }, %)`