Skip to content

Commit a42b6cc

Browse files
nrcnrc
committed
More warnings
Signed-off-by: Nick Cameron <[email protected]>
1 parent 4b4960a commit a42b6cc

File tree

14 files changed

+195
-162
lines changed

14 files changed

+195
-162
lines changed

‎e2e/playwright/editor-tests.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -912,7 +912,7 @@ a1 = startSketchOn(offsetPlane(XY, offset = 10))
912912
|> close()
913913
|> revolve(
914914
axis = revolveAxis,
915-
angle = 90
915+
angle = 90deg
916916
)
917917
`
918918
)

‎e2e/playwright/point-click.spec.ts

Lines changed: 64 additions & 66 deletions
Large diffs are not rendered by default.

‎e2e/playwright/sketch-tests.spec.ts

Lines changed: 49 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -2100,8 +2100,8 @@ profile003 = startProfile(sketch001, at = [206.63, -56.73])
21002100
)
21012101
await crnRect1point2()
21022102
await editor.expectEditor.toContain(
2103-
`|> angledLine(angle = 0, length = 2.37, tag = $rectangleSegmentA001)
2104-
|> angledLine(angle = segAng(rectangleSegmentA001) - 90, length = 7.8)
2103+
`|> angledLine(angle = 0deg, length = 2.37, tag = $rectangleSegmentA001)
2104+
|> angledLine(angle = segAng(rectangleSegmentA001) - 90deg, length = 7.8)
21052105
|> angledLine(angle = segAng(rectangleSegmentA001), length = -segLen(rectangleSegmentA001))
21062106
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
21072107
|> close()`.replaceAll('\n', '')
@@ -2115,8 +2115,8 @@ profile003 = startProfile(sketch001, at = [206.63, -56.73])
21152115
await crnRect2point2()
21162116
await page.waitForTimeout(300)
21172117
await editor.expectEditor.toContain(
2118-
`|> angledLine(angle = 0, length = 5.49, tag = $rectangleSegmentA002)
2119-
|> angledLine(angle = segAng(rectangleSegmentA002) - 90, length = 4.14)
2118+
`|> angledLine(angle = 0deg, length = 5.49, tag = $rectangleSegmentA002)
2119+
|> angledLine(angle = segAng(rectangleSegmentA002) - 90deg, length = 4.14)
21202120
|> angledLine(angle = segAng(rectangleSegmentA002), length = -segLen(rectangleSegmentA002))
21212121
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
21222122
|> close()`.replaceAll('\n', '')
@@ -2134,8 +2134,8 @@ profile003 = startProfile(sketch001, at = [206.63, -56.73])
21342134
await cntrRect1point2()
21352135
await page.waitForTimeout(300)
21362136
await editor.expectEditor.toContain(
2137-
`|> angledLine(angle = 0, length = 7.06, tag = $rectangleSegmentA003)
2138-
|> angledLine(angle = segAng(rectangleSegmentA003) + 90, length = 4.34)
2137+
`|> angledLine(angle = 0deg, length = 7.06, tag = $rectangleSegmentA003)
2138+
|> angledLine(angle = segAng(rectangleSegmentA003) + 90deg, length = 4.34)
21392139
|> angledLine(angle = segAng(rectangleSegmentA003), length = -segLen(rectangleSegmentA003))
21402140
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
21412141
|> close()`.replaceAll('\n', '')
@@ -2150,8 +2150,8 @@ profile003 = startProfile(sketch001, at = [206.63, -56.73])
21502150
await cntrRect2point2()
21512151
await page.waitForTimeout(300)
21522152
await editor.expectEditor.toContain(
2153-
`|> angledLine(angle = 0, length = 3.12, tag = $rectangleSegmentA004)
2154-
|> angledLine(angle = segAng(rectangleSegmentA004) + 90, length = 6.24)
2153+
`|> angledLine(angle = 0deg, length = 3.12, tag = $rectangleSegmentA004)
2154+
|> angledLine(angle = segAng(rectangleSegmentA004) + 90deg, length = 6.24)
21552155
|> angledLine(angle = segAng(rectangleSegmentA004), length = -segLen(rectangleSegmentA004))
21562156
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
21572157
|> close()`.replaceAll('\n', '')
@@ -2300,8 +2300,8 @@ profile001 = startProfile(sketch001, at = [6.24, 4.54])
23002300
|> line(end = [8.61, 0.74])
23012301
|> line(end = [10.99, -5.22])
23022302
profile002 = startProfile(sketch001, at = [11.19, 5.02])
2303-
|> angledLine(angle = 0, length = 10.78, tag = $rectangleSegmentA001)
2304-
|> angledLine(angle = segAng(rectangleSegmentA001) - 90, length = 4.14)
2303+
|> angledLine(angle = 0deg, length = 10.78, tag = $rectangleSegmentA001)
2304+
|> angledLine(angle = segAng(rectangleSegmentA001) - 90deg, length = 4.14)
23052305
|> angledLine(angle = segAng(rectangleSegmentA001), length = -segLen(rectangleSegmentA001))
23062306
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
23072307
|> close()
@@ -2373,7 +2373,7 @@ profile004 = circleThreePoint(sketch001, p1 = [13.44, -6.8], p2 = [13.39, -2.07]
23732373
await page.mouse.up()
23742374
await page.waitForTimeout(200)
23752375
await editor.expectEditor.toContain(
2376-
`angledLine(angle = -7, length = 10.27, tag = $rectangleSegmentA001)`
2376+
`angledLine(angle = -2deg, length = 10.2, tag = $rectangleSegmentA001)`
23772377
)
23782378
})
23792379

@@ -2415,8 +2415,8 @@ profile004 = circleThreePoint(sketch001, p1 = [13.44, -6.8], p2 = [13.39, -2.07]
24152415
await page.waitForTimeout(100)
24162416
await rectEnd()
24172417
await editor.expectEditor.toContain(
2418-
`|> angledLine(angle = 180, length = 1.97, tag = $rectangleSegmentA002)
2419-
|> angledLine(angle = segAng(rectangleSegmentA002) + 90, length = 3.89)
2418+
`|> angledLine(angle = 180deg, length = 1.97, tag = $rectangleSegmentA002)
2419+
|> angledLine(angle = segAng(rectangleSegmentA002) + 90deg, length = 3.89)
24202420
|> angledLine(angle = segAng(rectangleSegmentA002), length = -segLen(rectangleSegmentA002))
24212421
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
24222422
|> close()`.replaceAll('\n', '')
@@ -2441,8 +2441,8 @@ profile001 = startProfile(sketch001, at = [6.24, 4.54])
24412441
|> line(end = [8.61, 0.74])
24422442
|> line(end = [10.99, -5.22])
24432443
profile002 = startProfile(sketch001, at = [11.19, 5.02])
2444-
|> angledLine(angle = 0, length = 10.78, tag = $rectangleSegmentA001)
2445-
|> angledLine(angle = segAng(rectangleSegmentA001) - 90, length = 4.14)
2444+
|> angledLine(angle = 0deg, length = 10.78, tag = $rectangleSegmentA001)
2445+
|> angledLine(angle = segAng(rectangleSegmentA001) - 90deg, length = 4.14)
24462446
|> angledLine(angle = segAng(rectangleSegmentA001), length = -segLen(rectangleSegmentA001))
24472447
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
24482448
|> close()
@@ -2771,8 +2771,8 @@ profile002 = startProfile(sketch002, at = [0.75, 13.46])
27712771
|> line(end = [4.52, 3.79])
27722772
|> line(end = [5.98, -2.81])
27732773
profile003 = startProfile(sketch002, at = [3.19, 13.3])
2774-
|> angledLine(angle = 0, length = 6.64, tag = $rectangleSegmentA001)
2775-
|> angledLine(angle = segAng(rectangleSegmentA001) - 90, length = 2.81)
2774+
|> angledLine(angle = 0deg, length = 6.64, tag = $rectangleSegmentA001)
2775+
|> angledLine(angle = segAng(rectangleSegmentA001) - 90deg, length = 2.81)
27762776
|> angledLine(angle = segAng(rectangleSegmentA001), length = -segLen(rectangleSegmentA001))
27772777
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
27782778
|> close()
@@ -2789,7 +2789,7 @@ profile006 = startProfile(sketch002, at = [9.65, 3.82])
27892789
|> close()
27902790
revolve001 = revolve(
27912791
profile004,
2792-
angle = 45,
2792+
angle = 45deg,
27932793
axis = getNextAdjacentEdge(seg01)
27942794
)
27952795
extrude002 = extrude(profile006, length = 4)
@@ -2813,8 +2813,8 @@ profile010 = circle(
28132813
radius = 2.67
28142814
)
28152815
profile011 = startProfile(sketch003, at = [5.07, -6.39])
2816-
|> angledLine(angle = 0, length = 4.54, tag = $rectangleSegmentA002)
2817-
|> angledLine(angle = segAng(rectangleSegmentA002) - 90, length = 4.17)
2816+
|> angledLine(angle = 0deg, length = 4.54, tag = $rectangleSegmentA002)
2817+
|> angledLine(angle = segAng(rectangleSegmentA002) - 90deg, length = 4.17)
28182818
|> angledLine(angle = segAng(rectangleSegmentA002), length = -segLen(rectangleSegmentA002))
28192819
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
28202820
|> close()
@@ -2966,7 +2966,7 @@ loft([profile001, profile002])
29662966
)
29672967
await rect1Crn2()
29682968
await editor.expectEditor.toContain(
2969-
`angledLine(angle = 0, length = 113.01, tag = $rectangleSegmentA001)`
2969+
`angledLine(angle = 0deg, length = 113.01, tag = $rectangleSegmentA001)`
29702970
)
29712971
})
29722972
test('Can enter sketch loft edges offsetPlane and continue sketch', async ({
@@ -3035,7 +3035,7 @@ loft([profile001, profile002])
30353035
)
30363036
await rect1Crn2()
30373037
await editor.expectEditor.toContain(
3038-
`angledLine(angle = 0, length = 106.42], tag = $rectangleSegmentA001)`
3038+
`angledLine(angle = 0deg, length = 106.42], tag = $rectangleSegmentA001)`
30393039
)
30403040
await page.waitForTimeout(100)
30413041
})
@@ -3257,8 +3257,8 @@ test.describe('manual edits during sketch mode', () => {
32573257
extrude001 = extrude(profile001, length = 500)
32583258
sketch002 = startSketchOn(extrude001, face = seg01)
32593259
profile002 = startProfile(sketch002, at = [83.39, 329.15])
3260-
|> angledLine(angle = 0, length = 119.61, tag = $rectangleSegmentA001)
3261-
|> angledLine(length = 156.54, angle = -28)
3260+
|> angledLine(angle = 0deg, length = 119.61, tag = $rectangleSegmentA001)
3261+
|> angledLine(length = 156.54, angle = -28deg)
32623262
|> angledLine(
32633263
angle = -151,
32643264
length = 116.27,
@@ -3296,7 +3296,9 @@ test.describe('manual edits during sketch mode', () => {
32963296
await expect
32973297
.poll(
32983298
async () => {
3299-
await editor.expectEditor.toContain('length = 156.54, angle = -28')
3299+
await editor.expectEditor.toContain(
3300+
'length = 156.54, angle = -28deg'
3301+
)
33003302
await page.mouse.move(handle1Location.x, handle1Location.y)
33013303
await page.mouse.down()
33023304
await page.mouse.move(
@@ -3307,7 +3309,9 @@ test.describe('manual edits during sketch mode', () => {
33073309
}
33083310
)
33093311
await page.mouse.up()
3310-
await editor.expectEditor.toContain('length = 231.59, angle = -34')
3312+
await editor.expectEditor.toContain(
3313+
'length = 231.59, angle = -34deg'
3314+
)
33113315
return true
33123316
},
33133317
{ timeout: 10_000 }
@@ -3325,7 +3329,7 @@ test.describe('manual edits during sketch mode', () => {
33253329

33263330
const handle2Location = { x: 872, y: 273 }
33273331
await test.step('Edit sketch again', async () => {
3328-
await editor.expectEditor.toContain('length = 231.59, angle = -34')
3332+
await editor.expectEditor.toContain('length = 231.59, angle = -34deg')
33293333
await page.waitForTimeout(500)
33303334
await expect
33313335
.poll(
@@ -3336,7 +3340,9 @@ test.describe('manual edits during sketch mode', () => {
33363340
steps: 5,
33373341
})
33383342
await page.mouse.up()
3339-
await editor.expectEditor.toContain('length = 167.36, angle = -14')
3343+
await editor.expectEditor.toContain(
3344+
'length = 167.36, angle = -14deg'
3345+
)
33403346
return true
33413347
},
33423348
{ timeout: 10_000 }
@@ -3361,14 +3367,18 @@ test.describe('manual edits during sketch mode', () => {
33613367
await expect
33623368
.poll(
33633369
async () => {
3364-
await editor.expectEditor.toContain('length = 167.36, angle = -14')
3370+
await editor.expectEditor.toContain(
3371+
'length = 167.36, angle = -14deg'
3372+
)
33653373
await page.mouse.move(handle3Location.x, handle3Location.y)
33663374
await page.mouse.down()
33673375
await page.mouse.move(handle3Location.x, handle3Location.y + 110, {
33683376
steps: 5,
33693377
})
33703378
await page.mouse.up()
3371-
await editor.expectEditor.toContain('length = 219.2, angle = -56')
3379+
await editor.expectEditor.toContain(
3380+
'length = 219.2, angle = -56deg'
3381+
)
33723382
return true
33733383
},
33743384
{ timeout: 10_000 }
@@ -3393,9 +3403,9 @@ profile001 = startProfile(sketch001, at = [106.68, 89.77])
33933403
extrude001 = extrude(profile001, length = 500)
33943404
sketch002 = startSketchOn(extrude001, face = seg01)
33953405
profile002 = startProfile(sketch002, at = [83.39, 329.15])
3396-
|> angledLine(angle = 0, length = 119.61, tag = $rectangleSegmentA001)
3397-
|> angledLine(length = 219.2, angle = -56)
3398-
|> angledLine(angle = -151, length = 116.27)
3406+
|> angledLine(angle = 0deg, length = 119.61, tag = $rectangleSegmentA001)
3407+
|> angledLine(length = 219.2, angle = -56deg)
3408+
|> angledLine(angle = -151deg, length = 116.27)
33993409
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
34003410
|> close()
34013411
profile003 = startProfile(sketch002, at = [-201.08, 254.17])
@@ -3432,10 +3442,10 @@ profile003 = startProfile(sketch002, at = [-201.08, 254.17])
34323442
extrude001 = extrude(profile001, length = 500)
34333443
sketch002 = startSketchOn(extrude001, face = seg01)
34343444
profile002 = startProfile(sketch002, at = [83.39, 329.15])
3435-
|> angledLine(angle = 0, length = 119.61, tag = $rectangleSegmentA001)
3436-
|> angledLine(length = 156.54, angle = -28)
3445+
|> angledLine(angle = 0deg, length = 119.61, tag = $rectangleSegmentA001)
3446+
|> angledLine(length = 156.54, angle = -28deg)
34373447
|> angledLine(
3438-
angle = -151,
3448+
angle = -151deg,
34393449
length = 116.27,
34403450
)
34413451
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
@@ -3496,10 +3506,10 @@ profile003 = startProfile(sketch002, at = [-201.08, 254.17])
34963506
extrude001 = extrude(profile001, length = 500)
34973507
sketch002 = startSketchOn(extrude001, face = seg01)
34983508
profile002 = startProfile(sketch002, at = [83.39, 329.15])
3499-
|> angledLine(angle = 0, length = 119.61, tag = $rectangleSegmentA001)
3500-
|> angledLine(length = 156.54, angle = -28)
3509+
|> angledLine(angle = 0deg, length = 119.61, tag = $rectangleSegmentA001)
3510+
|> angledLine(length = 156.54, angle = -28deg)
35013511
|> angledLine(
3502-
angle = -151,
3512+
angle = -151deg,
35033513
length = 116.27,
35043514
)
35053515
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])

‎e2e/playwright/snapshot-tests.spec.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -845,14 +845,14 @@ test.describe('code color goober', { tag: '@snapshot' }, () => {
845845
sweepPath = startSketchOn(XZ)
846846
|> startProfile(at = [0.05, 0.05])
847847
|> line(end = [0, 7])
848-
|> tangentialArc(angle = 90, radius = 5)
848+
|> tangentialArc(angle = 90deg, radius = 5)
849849
|> line(end = [-3, 0])
850-
|> tangentialArc(angle = -90, radius = 5)
850+
|> tangentialArc(angle = -90deg, radius = 5)
851851
|> line(end = [0, 7])
852852
853853
sweepSketch = startSketchOn(XY)
854854
|> startProfile(at = [2, 0])
855-
|> arc(angleStart = 0, angleEnd = 360, radius = 2)
855+
|> arc(angleStart = 0, angleEnd = 360deg, radius = 2)
856856
|> sweep(path = sweepPath)
857857
|> appearance(
858858
color = "#bb00ff",
@@ -889,14 +889,14 @@ sweepSketch = startSketchOn(XY)
889889
sweepPath = startSketchOn(XZ)
890890
|> startProfile(at = [0.05, 0.05])
891891
|> line(end = [0, 7])
892-
|> tangentialArc(angle = 90, radius = 5)
892+
|> tangentialArc(angle = 90deg, radius = 5)
893893
|> line(end = [-3, 0])
894-
|> tangentialArc(angle = -90, radius = 5)
894+
|> tangentialArc(angle = -90deg, radius = 5)
895895
|> line(end = [0, 7])
896896
897897
sweepSketch = startSketchOn(XY)
898898
|> startProfile(at = [2, 0])
899-
|> arc(angleStart = 0, angleEnd = 360, radius = 2)
899+
|> arc(angleStart = 0deg, angleEnd = 360deg, radius = 2)
900900
|> sweep(path = sweepPath)
901901
|> appearance(
902902
color = '#bb00ff',
@@ -934,14 +934,14 @@ sweepSketch = startSketchOn(XY)
934934
sweepPath = startSketchOn(XZ)
935935
|> startProfile(at = [0.05, 0.05])
936936
|> line(end = [0, 7])
937-
|> tangentialArc(angle = 90, radius = 5)
937+
|> tangentialArc(angle = 90deg, radius = 5)
938938
|> line(end = [-3, 0])
939-
|> tangentialArc(angle = -90, radius = 5)
939+
|> tangentialArc(angle = -90deg, radius = 5)
940940
|> line(end = [0, 7])
941941
942942
sweepSketch = startSketchOn(XY)
943943
|> startProfile(at = [2, 0])
944-
|> arc(angleStart = 0, angleEnd = 360, radius = 2)
944+
|> arc(angleStart = 0deg, angleEnd = 360deg, radius = 2)
945945
|> sweep(path = sweepPath)
946946
|> appearance(
947947
color = "#bb00ff",

0 commit comments

Comments
 (0)