Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron release: new scene building indicator not working #3767

Open
jessfraz opened this issue Sep 4, 2024 · 1 comment
Open

electron release: new scene building indicator not working #3767

jessfraz opened this issue Sep 4, 2024 · 1 comment
Assignees
@lf94 @nadr0
Labels
bug Something isn't working high-priority tests Pull requests that update or improve our test suite
Milestone
v1 Modeling App L...

Comments

@jessfraz
Copy link
Contributor

jessfraz commented Sep 4, 2024

The export command makes the new "are we done rendering" indicator Lee added to the bottom hang in it's spinning state, I suspect because it makes the last command message received back not be an "execution-done" message.
@jessfraz jessfraz added bug Something isn't working high-priority labels Sep 4, 2024
@jessfraz jessfraz added this to the v1 Modeling App Launch milestone Sep 4, 2024
@nadr0 nadr0 mentioned this issue Sep 4, 2024
Merged
@nadr0 nadr0 self-assigned this Sep 4, 2024
@jessfraz
Copy link
Contributor Author

jessfraz commented Sep 4, 2024

fixed in #3770 but will need a regression test

@jessfraz jessfraz added the tests Pull requests that update or improve our test suite label Sep 4, 2024
@nadr0 nadr0 mentioned this issue Sep 4, 2024
Closed
@lf94 lf94 assigned lf94 and nadr0 and unassigned nadr0 and lf94 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lf94 lf94

@nadr0 nadr0

Labels
bug Something isn't working high-priority tests Pull requests that update or improve our test suite
Projects
None yet
Milestone
v1 Modeling App Launch
Development

Successfully merging a pull request may close this issue.

Adding extra checks in file exporting to make sure the spinner resolves KittyCAD/modeling-app
3 participants
@lf94 @jessfraz @nadr0