Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large files are unusable in the code editor #3786

Closed
Irev-Dev opened this issue Sep 5, 2024 · 9 comments
Closed

Large files are unusable in the code editor #3786

Irev-Dev opened this issue Sep 5, 2024 · 9 comments
Assignees
Labels
bug Something isn't working high-priority performance

Comments

@Irev-Dev
Copy link
Collaborator

Irev-Dev commented Sep 5, 2024

Likely something the react profiler will help fix because this feels like the main thread is getting blocked.

Notice the key spam but the cursor moves in jumps.

Screen.Recording.2024-09-04.at.7.53.19.PM.mov
@Irev-Dev Irev-Dev added bug Something isn't working performance labels Sep 5, 2024
@lf94
Copy link
Contributor

lf94 commented Sep 5, 2024

i fear this touches a few things

@jessfraz
Copy link
Contributor

jessfraz commented Sep 5, 2024

I highly doubt it is any of the codemirror code tho, or plugins since none of those changed in the electron port and now all of a sudden its doing this, which makes me lean towards react

@jessfraz
Copy link
Contributor

jessfraz commented Sep 5, 2024

isnt happening in the browser for me

@jessfraz
Copy link
Contributor

jessfraz commented Sep 5, 2024

actually finding it hard to repro on the latest build off the main branch on desktop too, but let me try a larger model

@jessfraz
Copy link
Contributor

jessfraz commented Sep 5, 2024

okay yep its large files

@jessfraz
Copy link
Contributor

jessfraz commented Sep 5, 2024

try the server rack

@jessfraz
Copy link
Contributor

jessfraz commented Sep 5, 2024

Screenshare.-.2024-09-05.1_29_06.PM.mp4

@Irev-Dev
Copy link
Collaborator Author

Irev-Dev commented Sep 5, 2024

If it's large files, my gut guess would be that we're maybe parsing the code on cursor moves when we should only do that on actual text change, and that's blocking the main thread.

@Irev-Dev Irev-Dev changed the title Bug: fix "keyboard batching" when moving mouse in editor Bug: fix "keyboard batching" when moving cursor in editor Sep 6, 2024
@lf94 lf94 changed the title Bug: fix "keyboard batching" when moving cursor in editor Large files are unusable in the code editor Sep 6, 2024
@lf94 lf94 self-assigned this Sep 6, 2024
@lf94 lf94 closed this as completed Sep 6, 2024
@adamchalmers
Copy link
Collaborator

adamchalmers commented Sep 6, 2024

@lf94 is #3825 the PR which fixed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority performance
Projects
None yet
Development

No branches or pull requests

4 participants