Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opening a project going from dark mode to light mode does not work well #3805

Closed
jessfraz opened this issue Sep 5, 2024 · 2 comments · Fixed by #3845
Closed

opening a project going from dark mode to light mode does not work well #3805

jessfraz opened this issue Sep 5, 2024 · 2 comments · Fixed by #3845
Assignees
Labels
bug Something isn't working high-priority

Comments

@jessfraz
Copy link
Contributor

jessfraz commented Sep 5, 2024

either we should fix it or remove the ability to have different themed projects

Screenshare.-.2024-09-05.1_48_00.PM.mp4
@jessfraz jessfraz added bug Something isn't working high-priority labels Sep 5, 2024
@adamchalmers
Copy link
Collaborator

I think Dark/Light Theme should be an app-wide setting, not per-project. I've never seen any other software offer per-project light/dark theme.

@franknoirot franknoirot self-assigned this Sep 9, 2024
@franknoirot
Copy link
Collaborator

Yeah I agree, and we turned off Theme as a project-level setting in #3312. I think the settings parsing system would still pick it up though, what that PR did was just turn off users' ability to change the setting, not whether the app would respect it. @jessfraz does that project you opened in your video have a theme setting in its project.toml?

I think the visual regression is not really the result of that, but rather due to some hasty changes I made to global CSS while trying to create #3794. I suspect light OS + dark theme and dark OS + light theme are what is happening here. It's the same issue I'm trying to fix for Josh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants