Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron app sign in page slow #3814

Open
jessfraz opened this issue Sep 6, 2024 · 1 comment
Open

electron app sign in page slow #3814

jessfraz opened this issue Sep 6, 2024 · 1 comment

Comments

@jessfraz
Copy link
Contributor

jessfraz commented Sep 6, 2024

i think its just the router, doing like what do i render are they authed logic, but likely its crazy inefficient, but compare an auth-ed double click of a file to just openign the app unauthed and its nuts that the first is faster.

marked as high priority since this is the first impression people get of the app

@TomPridham
Copy link

I looked into this a bit over the weekend. Overall, the app loads pretty quickly for me with an installed .deb package. Running the app with yarn tron:start is pretty consistently slow(which I think should be expected somewhat since it isn't running in release mode) on the first start for me. This is due to needing to create the WebGLRenderer as part of the app setup Image
After the initial load, that same setup is between 400ms and 1500ms. I tried to lazily create the SceneInfra class which creates the WebGLRenderer, but it's pretty tied in to the initial setup of the app and I didn't want to do a heavier refactor without confirming that was the actual problem or if there was something else you were referring to. I'm also not sure if it's a platform thing, the problem could be completely different on Mac or Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants