Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screenshot attached to this issue is not what I see on my screen #3079

Open
spoon16 opened this issue Jul 19, 2024 · 1 comment · May be fixed by #3917
Open

Screenshot attached to this issue is not what I see on my screen #3079

spoon16 opened this issue Jul 19, 2024 · 1 comment · May be fixed by #3917
Assignees
@nadr0
Labels
bug Something isn't working coredump Issues that contain a coredump.
Milestone
v1 Modeling App L...

Comments

@spoon16
Copy link

spoon16 commented Jul 19, 2024

Playing around, got the Modeling App to render the viewport in a way that was not stretching to view the available space. Hit the button to create an issue in the top right. This screenshot does not match what I was seeing, unfortunately I did not take my own screenshot and when I flipped back to the app it looked fine again. Thought it also did not match the screenshot attached here.

Flagging that your screenshot implementation might not be capturing exactly what your users are seeing.

Screenshot

Core Dump

coredump-9c69b342-d8b7-4789-b87f-d7db064da12a.json

Reference ID: 9c69b342-d8b7-4789-b87f-d7db064da12a
@jessfraz jessfraz added bug Something isn't working coredump Issues that contain a coredump. labels Jul 20, 2024
@jessfraz jessfraz added this to the v1 Modeling App Launch milestone Jul 20, 2024
@nadr0 nadr0 self-assigned this Sep 17, 2024
@nadr0
Copy link
Collaborator

nadr0 commented Sep 17, 2024

I am able to recreate this issue. The library that is used for screenshots is html2canvas-pro. It appears to work well for the website based application but when it runs in electron it renders incorrectly. I'll investigate further.

@nadr0 nadr0 linked a pull request Sep 18, 2024 that will close this issue
Open
@spoon16 spoon16 mentioned this issue Oct 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadr0 nadr0

Labels
bug Something isn't working coredump Issues that contain a coredump.
Projects
None yet
Milestone
v1 Modeling App Launch
Development

Successfully merging a pull request may close this issue.

Nadro/3079/screenshot improvements KittyCAD/modeling-app
3 participants
@spoon16 @jessfraz @nadr0