You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the user has created a plane using either the offsetPlane or other plane-creating function in KCL (or via the UI after #2213 is complete), we should show them as a real plane in the scene that can be selected and therefore sketched on. Once #4274 is complete, these planes' visibility should also be able to be toggled within the feature tree's UI.
The following KCL code should result in a circle on the XY plane with a plane shown 10 units above it:
None. This would be a similar flow to the one used by the default planes, so should require nothing special to implement.
API/KCL notes
Might need to add something to the API layer to create a visible plane that represents the plane, and return its UUID to the frontend?
Point-and-click notes
Might need some logic on the frontend controlling what visibility to give a plane by default: if an offset plane has a sketch on it, maybe it should be hidden by default.
I'm not sure if the "autoscaling" behavior shown by the default planes would apply to these offset planes as well.
The text was updated successfully, but these errors were encountered:
Alter the return type of the WASM offset_plane to return an entity ID in addition to its PlaneData, and add a side-effect function like make_default_plane that fires off the engine commands to create a visible plane representation.
Update any tests, doc comments, etc that need to in order to support this
Update the client side to add offset planes to the artifact graph
Add to artifact graph tests, etc to support this
Add or alter a snapshot test and a sketch-on-face test to ensure this new plane is usable.
If the user has created a plane using either the
offsetPlane
or other plane-creating function in KCL (or via the UI after #2213 is complete), we should show them as a real plane in the scene that can be selected and therefore sketched on. Once #4274 is complete, these planes' visibility should also be able to be toggled within the feature tree's UI.The following KCL code should result in a circle on the XY plane with a plane shown 10 units above it:
Engine notes
None. This would be a similar flow to the one used by the default planes, so should require nothing special to implement.
API/KCL notes
Point-and-click notes
The text was updated successfully, but these errors were encountered: