Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve toolbar UX #4469

Open
nadr0 opened this issue Nov 12, 2024 · 1 comment
Open

Improve toolbar UX #4469

nadr0 opened this issue Nov 12, 2024 · 1 comment
Assignees

Comments

@nadr0
Copy link
Collaborator

nadr0 commented Nov 12, 2024

When implementing the Center Rectangle tool I came across several UX issues within the toolbar. To prevent bloating center rectangle I've outlined these preexisting issues below.

  1. EscL or L, when active it shows Esc (keybinds), the copy is confusing.
  2. If action button is focused and you press keybinds the tooltip is kept focused (the old one is kept opened)
  3. Action array dropdown still shows focused tooltip when dropdown is open
  4. Select the dropdown actionbutton properly
  5. Select the tooltip actionbutton properly
  6. If you click to disable the tool you still see the tooltip due to focus
  7. If you have a tool selected then focus is applied the hover tooltip is under the focused tooltip
  8. Allow for multiple icon types within dropdown menus.
2024-11-12.11-10-33.mp4

I'd recommend removing the focus logic on tooltips and keep it to hover.

I think a lot of tools do not have tooltips stay open when focused, usually on hover. Excalidraw does have a little description but that is separate from the Tooltip. We both embed a description keybind, usage all into a single tooltip.

Image

@franknoirot
Copy link
Collaborator

The focus logic is in a probably naïve attempt at accessibility, but I support whatever we need to do to make these feel better including removing it and/or splitting out the description as you suggested. One thing to consider checking is if we've been using :focus where we should have been using :focus-visible, which should not appear on click interactions, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants