Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Fillet Function to Support Chamfers #4527

Open
Tracked by #2606
max-mrgrsk opened this issue Nov 20, 2024 · 1 comment · May be fixed by #4593
Open
Tracked by #2606

Refactor Fillet Function to Support Chamfers #4527

max-mrgrsk opened this issue Nov 20, 2024 · 1 comment · May be fixed by #4593
Assignees
@max-mrgrsk
Labels
feature Feature Requests

Comments

@max-mrgrsk
Copy link
Collaborator

max-mrgrsk commented Nov 20, 2024 •
edited
Loading

Expand the current fillet functionality to also support chamfer operations by adding a parameter for the operation type. Avoid duplicating logic for the two operations.
@max-mrgrsk max-mrgrsk mentioned this issue Nov 20, 2024
Open
36 tasks
@max-mrgrsk max-mrgrsk changed the title Refactor fillet into function that works with chamfers Refactor Fillet Function to Support Chamfers Nov 20, 2024
@max-mrgrsk max-mrgrsk self-assigned this Nov 20, 2024
@max-mrgrsk max-mrgrsk added the feature Feature Requests label Nov 20, 2024
@max-mrgrsk
Copy link
Collaborator Author

Naming ideas:

EdgeTreatment / EdgeModification / EdgeOperation / EdgeProfile
Fimfer / Chamlet / Filcham / Chamfil
EdgeTransform / EdgeMorph / BlendCut / EdgeCut

@max-mrgrsk max-mrgrsk linked a pull request Nov 27, 2024 that will close this issue
Refactor addFillet into addEdgeTreatment Function Supporting Chamfers #4593
Draft
@max-mrgrsk max-mrgrsk linked a pull request Nov 27, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@max-mrgrsk max-mrgrsk

Labels
feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor addFillet into addEdgeTreatment Function Supporting Chamfers KittyCAD/modeling-app
1 participant
@max-mrgrsk