Deletion of Sketch on Offset Plane in the feature tree misses the profiles

[pierremtb]

          Just noticed this deletion of Sketch in the feature tree leads to the sketch var to be delete but not the profiles in it. This can totally be fixed in a subsequent PR, I can take care of opening up a new issue for this. 

Screen.Recording.2025-02-14.at.8.43.35.AM.copy.mov

Originally posted by @pierremtb in #5196 (comment)

[franknoirot]

This is definitely something to do with deleteFromSelection, which added cases at the top of the function (using artifact graph logic) to delete the paths when a sketch plane is deleted. It must not be properly catching the case of a plane artifact that is an offset plane.

@jtran expressed some concern that this has something to do with the artifact graph representation of offset planes, so I want to leave space in case that is where the problem actually lies. That would probably be something about sketches on offset planes creating new plane artifacts.

[franknoirot]

Okay yes, this is related to the artifact graph representation of offset planes. Selecting the sketch item that is on an offset plane gets a null artifact, then the source range is naive and only deletes the plane's declaration line.

[franknoirot]

I think this is the TODO that I need to...do. https://github.com/KittyCAD/modeling-app/blob/main/src/wasm-lib/kcl/src/execution/artifact.rs#L344-L346

[jtran]

We should chat about this.

[jtran]

Does this branch, adding the code ref, help at all? main...jtran/plane-code-ref

[franknoirot]

Does this branch, adding the code ref, help at all? main...jtran/plane-code-ref

Let me try @jtran, thanks!

[franknoirot]

@jtran I don't think I can see this codeRef in the artifactGraph because "sketch" type artifacts are not included there? Let me know if I'm mistaken though

Screenshare.-.2025-02-20.12_22_23.PM-compressed.mp4

[jtran]

The TODO and the code_ref branch so far only affects sketch-on-face. Specifically if you use startSketchOn() with a Plane or a Solid. You're using 'XZ', which uses the PlaneData type. So the branch has no effect there. We can huddle about this to discuss next steps.

[franknoirot]

The TODO and the code_ref branch so far only affects sketch-on-face. Specifically if you use startSketchOn() with a Plane or a Solid. You're using 'XZ', which uses the PlaneData type. So the branch has no effect there. We can huddle about this to discuss next steps.

I'm a little confused, here's my KCL code:

plane001 = offsetPlane('XZ', offset = 5)
sketch001 = startSketchOn(plane001)
    |> circle({ center = [0, 0], radius = 5 }, %)

I though I was using startSketchOn() with a Plane; a new plane offset from 'XZ' by 5 units?