Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the last windows test not passing #3644

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

iterion
Copy link
Contributor

@iterion iterion commented Aug 23, 2024

This test passes on my windows machine, so I'm just gonna use this branch to test out a few ideas to try to get it working on CI.

closes #3557

Copy link

qa-wolf bot commented Aug 23, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Sep 4, 2024 2:12pm

@iterion iterion force-pushed the iterion/enable-last-win32-test branch from d8ef119 to 05c5a78 Compare September 3, 2024 18:29
@franknoirot
Copy link
Collaborator

Okay so the one test changed in this PR and re-enabled on Windows is the one test not passing on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove win32 skips
3 participants