Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Fillet Logic to Combine Multiple Tags Within the Same Fillet Expression #4058

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Refactor Fillet Logic to Combine Multiple Tags Within the Same Fillet Expression #4058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
39eefa8
combine tags + tests
max-mrgrsk Oct 1, 2024
f2e5952
delete getFilletTag function
max-mrgrsk Oct 1, 2024
afef412
fix playwright test
max-mrgrsk Oct 2, 2024
2b3a729
make eslint happy
max-mrgrsk Oct 2, 2024
bf30b7c
Merge branch 'main' of https://github.com/KittyCAD/modeling-app into …
max-mrgrsk Oct 2, 2024
e504e68
delete missed 'const'
max-mrgrsk Oct 2, 2024
bc288f3
delete const rev2
max-mrgrsk Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions e2e/playwright/command-bar-tests.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,11 @@ extrude001 = extrude(-10, sketch001)`
await page.waitForTimeout(100)
await page.getByRole('button', { name: 'Fillet' }).click()
await page.waitForTimeout(100)
await page.keyboard.press('Enter')
await page.keyboard.press('Enter') // skip selection
await page.waitForTimeout(100)
await page.keyboard.press('Enter')
await page.keyboard.press('Enter') // accept default radius
await page.waitForTimeout(100)
await page.keyboard.press('Enter') // submit
await page.waitForTimeout(100)
await expect(page.locator('.cm-activeLine')).toContainText(
`fillet({ radius: ${KCL_DEFAULT_LENGTH}, tags: [seg01] }, %)`
Expand Down
Loading
Loading