Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut release v0.25.6 #4111

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Cut release v0.25.6 #4111

merged 2 commits into from
Oct 8, 2024

Conversation

nadr0
Copy link
Collaborator

@nadr0 nadr0 commented Oct 7, 2024

What's Changed

Full Changelog: v0.25.5...v0.25.6

Copy link

qa-wolf bot commented Oct 7, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Oct 8, 2024 1:20am

@nadr0
Copy link
Collaborator Author

nadr0 commented Oct 7, 2024

Grab the out-ubuntu-22.04 AppImage from the build-publish-apps job in the CI CD pipeline of the PR that has the cut release. Example scroll to the bottom and see the artifacts sections to download the file.

Gotcha: I had to chmod +x the file and install Fuse to get the AppImage running

Use: updater-test-ubuntu-22.04 from the artifacts page for the update tests.

  • Electron tests: external links open an external browser Electron tests: external links open an external browser #3373
  • coredump will open github issue with stuff populated (from home and project page) there are different ways to trigger it as well (! button at top, bug at bottom, mod + shift + .)
    • !
    • Bug bottom folder page
    • Bug bottom model render page
    • ❗ (Does not work on linux) mod + shift + .
  • running app.{app,exe} path/to/file opens the kcl file (all oses)
/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/Documents/zoo-modeling-app-projects/default/cube.kcl
  • running app.{app,exe} path/to/dir opens the directory and any kcl file in it or creates a main.kcl if empty (all oses)
    • Opens directory
    • Creates main file if empty
/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/Documents/zoo-modeling-app-projects/default
rm /home/kevin-nadro/Documents/zoo-modeling-app-projects/empty/main.kcl

/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/Documents/zoo-modeling-app-projects/empty
  • If someone at the office, test you can hit make from the app and it works
  • Test updating versions works
  • until we have a performance test, sanity check that time to open file directly from command line is not shit
    • 52.43s
/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/Documents/zoo-modeling-app-projects/default/chassis-with-rails.kcl
/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/smoke-test-file-permissions-linux/main.kcl

Notes

  • Opening a path to a directory that doesn't exist, hangs, should we create the directory?
Loading project at startup: /home/kevin-nadro/Documents/zoo-modeling-app-projects/empty-2
Error: ENOENT: no such file or directory, stat '/home/kevin-nadro/Documents/zoo-modeling-app-projects/empty-2'
[42821:0930/142409.906556:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times!
Checking for update
Update for version 0.25.5 is not available (latest version: 0.25.4, downgrade is disallowed).
  • Cannot figure out mod + shift + . on linux for core dump
  • Double clicking files on linux does not work.

@franknoirot
Copy link
Collaborator

franknoirot commented Oct 7, 2024

Windows smoke test (from #3588)

@nadr0
Copy link
Collaborator Author

nadr0 commented Oct 7, 2024

A note, the auto updater for linux x64 did not get generated and uploaded so I cannot test this workflow. We will need to figure out why it was not uploaded.

@lf94
Copy link
Contributor

lf94 commented Oct 7, 2024

Mac OS

Gotcha: I had to chmod +x the file and install Fuse to get the AppImage running

Use: updater-test-ubuntu-22.04 from the artifacts page for the update tests.

  • Electron tests: external links open an external browser Electron tests: external links open an external browser #3373
  • coredump will open github issue with stuff populated (from home and project page) there are different ways to trigger it as well (! button at top, bug at bottom, mod + shift + .)
    • !
    • Bug bottom folder page
    • Bug bottom model render page
    • ❗ (Does not work on linux) mod + shift + .
  • running app.{app,exe} path/to/file opens the kcl file (all oses)
/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/Documents/zoo-modeling-app-projects/default/cube.kcl
  • running app.{app,exe} path/to/dir opens the directory and any kcl file in it or creates a main.kcl if empty (all oses)
    • Opens directory
    • Creates main file if empty
/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/Documents/zoo-modeling-app-projects/default
rm /home/kevin-nadro/Documents/zoo-modeling-app-projects/empty/main.kcl

/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/Documents/zoo-modeling-app-projects/empty
  • If someone at the office, test you can hit make from the app and it works
  • Test updating versions works
  • until we have a performance test, sanity check that time to open file directly from command line is not shit
    • 00:00:02.63
/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/Documents/zoo-modeling-app-projects/default/chassis-with-rails.kcl
/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/smoke-test-file-permissions-linux/main.kcl

Notes

  • Opening a path to a directory that doesn't exist, hangs, should we create the directory?
Loading project at startup: /home/kevin-nadro/Documents/zoo-modeling-app-projects/empty-2
Error: ENOENT: no such file or directory, stat '/home/kevin-nadro/Documents/zoo-modeling-app-projects/empty-2'
[42821:0930/142409.906556:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times!
Checking for update
Update for version 0.25.5 is not available (latest version: 0.25.4, downgrade is disallowed).
  • Cannot figure out mod + shift + . on linux for core dump
  • Double clicking files on linux does not work.

@pierremtb
Copy link
Collaborator

Updater test checked on Windows and macOS

@franknoirot franknoirot enabled auto-merge (squash) October 8, 2024 00:38
@franknoirot franknoirot disabled auto-merge October 8, 2024 00:44
@franknoirot
Copy link
Collaborator

Vercel is having a partial outage right now with their Builds Queue, resulting in a hanging check here that I have to override to release. https://www.vercel-status.com/incidents/sxfvdhf3zxsq

@franknoirot franknoirot merged commit 7de0b74 into main Oct 8, 2024
25 of 26 checks passed
@franknoirot franknoirot deleted the cut-release-v0.25.6 branch October 8, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants