Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Data File Import for DIVE Desktop #1454

Open
BryonLewis opened this issue Nov 4, 2024 · 2 comments
Open

Additional Data File Import for DIVE Desktop #1454

BryonLewis opened this issue Nov 4, 2024 · 2 comments
Assignees
Labels
Type: Feature Request New feature or request

Comments

@BryonLewis
Copy link
Collaborator

This would be an additional file added to the DIVE Desktop when importing data. It would be an optional file that can be loaded into the system.

This file would then be added as an additional input when running pipelines (I assume it provides some additional context about information).

./platform/desktop/frontend/components/ImportDialog.vue - In here we would add an optional File that can be uploaded along with the existing media, annotation, metadata files. I'll ask in a comment below for some more information.

./client/dive-common/apispec.ts - Update the openFromDisk to have a new datasetType, which can be the new file type.

You then need to update in the ./client/platform/desktop/forntend/api.ts - the openFromDisk to handle the new file type.

Probably want to add this additional data file to the DIVE meta.json file. You can find examples in ~/VIAME_DATA/DIVE_Projects folder the meta.json file. So add some property to this that can be used to indicate the location of this file.

If you look in ./client/platform/desktop/backend/native/viame.ts you can find were a new command is for the calibration file. A similar type of input will be needed for this new file it happens to exists.

@BryonLewis BryonLewis added the Type: Feature Request New feature or request label Nov 4, 2024
@BryonLewis
Copy link
Collaborator Author

@mattdawkins

  • What should be a user face name for this additional File (Metadata file is already taken for DIVE Metadata)?
  • Is there an example pipeline that incorporates this new data and can you point to it? Ideally we would like to know the input command for the pipeline to add this new file as an input
  • Can you provide some sample data to run this pipeline to make sure it gets the proper results?

@mattdawkins
Copy link
Member

mattdawkins commented Nov 8, 2024

What should be a user face name for this additional File

Camera file is fine, though I think in the userface it should be listed as camera / metadata file since for some use cases this will be a metadata file and in some a camera file

Is there an example pipeline that incorporates this new data and can you point to it?

Currently only pipelines like this exist for stereo data, though we're making a monocular one in the near future which takes in one of the .json files files I've shared with you (Note some of these files are not public and shouldn't be attached here). There are .json, .cam, .npz and .mat files in that directory as formats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants