Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating pin of react #75

Open
WesleyTheGeolien opened this issue Jul 16, 2022 · 3 comments
Open

Updating pin of react #75

WesleyTheGeolien opened this issue Jul 16, 2022 · 3 comments

Comments

@WesleyTheGeolien
Copy link
Contributor

Hi guys,

I’m not too familiar with all the react ins and outs but when installing react-vtk-us in my project that is on react 17.X I am getting an incompatible versions errors.

Apparently this is due to my npm / node version? I can get around this by specifying —legacy-peer-deps but I believe that will be on all my packages and not just react-vtk-js.

I also tried forking and updating the pin to 16 || 17 5f9a91d

this seems to work in initial testing at least for the errors. Is there a reason this wouldn’t work long term?

I saw #67 but am. It entirely sure this is the same thing?

@floryst
Copy link
Collaborator

floryst commented Jul 18, 2022

Right now react-vtk-js is strictly react v16, unfortunately. #67 is related to this issue. We haven't been able to test react-vtk-js with v17 or v18. FYI efforts in #71 will help address this.

FYI @jourdain

@jourdain
Copy link
Collaborator

react-vtk-js could move to a newer version of react but it needs to remains compatible with react@16 so it can be used by Dash.

@WesleyTheGeolien
Copy link
Contributor Author

Ok thanks for the update on this guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants