Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Preprocessed Image Models #103

Open
jjnesbitt opened this issue Aug 17, 2022 · 0 comments
Open

Refactor Preprocessed Image Models #103

jjnesbitt opened this issue Aug 17, 2022 · 0 comments
Labels
minor Minor issue that can be worked on in the background

Comments

@jjnesbitt
Copy link
Collaborator

This isn't anything critical, but could allow performance improvements.

Currently, each preprocessed image has its own model (Feature, Registered, Jacobian, Segmented). In reality, these are mostly the same, with Feature and Registration each having an extra field. However, having them separated in this way makes logic and queries complicated, as we often want "all preprocessed images", which means asking for all of each image separately, and then combining them.

In reality, these models could be combined into one "PreprocessedImage" model, with a type field that is one of Feature, Registered, Jacobian or Segmented. We'd also want a metadata field to contain the extra type specific parameters that we'd need (Feature and Registered). We could even set up database constraints to ensure that they exist.

@jjnesbitt jjnesbitt added the minor Minor issue that can be worked on in the background label Aug 17, 2022
@jjnesbitt jjnesbitt added this to the Rounding out the application milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor issue that can be worked on in the background
Projects
None yet
Development

No branches or pull requests

1 participant