Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is easy to search for specific companies (or municipalities) in the ComparisionTable #550

Open
Greenheart opened this issue May 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request not ready This is not ready to be implemented. Do not work on this yet!

Comments

@Greenheart
Copy link
Collaborator

Investigate if there's an easy way to implement a basic search functionality.

Maybe add a search icon above the ComparisionTable that can be expanded into a search field.

When searching for something, ideally show suggestions based on the most relevant items from the list

When selecting an item from the search results, scroll to it in the table. Maybe using Element.scrollIntoView(). We could potentially get the DOM reference from the rendered table rows of @tanstack/table.

@Greenheart Greenheart added the enhancement New feature or request label May 13, 2024
@Greenheart Greenheart self-assigned this May 13, 2024
@Greenheart Greenheart added the not ready This is not ready to be implemented. Do not work on this yet! label May 14, 2024
@Greenheart
Copy link
Collaborator Author

Marking as not ready for now, since #551 will make it easier to navigate the table. Then we might reconsider this as part of the redesign.

@elvbom elvbom moved this to Ready in Klimatkollen web May 20, 2024
@elvbom elvbom moved this from Ready to Backlog in Klimatkollen web May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not ready This is not ready to be implemented. Do not work on this yet!
Projects
Status: Backlog
Development

No branches or pull requests

1 participant