Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider running python tests for releases, and PRs (if they modify anything in the data directory) #591

Open
Greenheart opened this issue May 20, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@Greenheart
Copy link
Collaborator

Greenheart commented May 20, 2024

Do we actually run Python tests during for releases and PRs? Both our GitHub workflows have the python tests commented out:

# Run Python tests
# Fixme: Uncomment when tests are added!
# - name: Run Python tests
# run: python3 -m unittest discover -s data/tests
and
# Run Python tests
# Fixme: Uncomment when tests are added!
# - name: Run Python tests
# run: python3 -m unittest discover -s data/tests

To make the Python tests only run when something has changed in the data directory (where the Python code exists), we might be use a command similar to this in the build step:

git diff --quiet HEAD^ HEAD data

This is commonly used to conditionally perform Vercel builds for projects where you only want specific changes to trigger new builds.

@Greenheart Greenheart added enhancement New feature or request question Further information is requested labels May 20, 2024
@elvbom elvbom moved this to Backlog in Klimatkollen web May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: Backlog
Development

No branches or pull requests

2 participants