Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React] Cannot minify package. #10

Open
Pruxis opened this issue May 17, 2018 · 1 comment
Open

[React] Cannot minify package. #10

Pruxis opened this issue May 17, 2018 · 1 comment

Comments

@Pruxis
Copy link

Pruxis commented May 17, 2018

When utilise CRA / Webpack in my project I am not able to compile it properly.

Everything works fine with my React build and this package is amazing, but I am forced now to utilise d3-flextree-v4 because that package has been exported as an es5 module

Documentation about CRA error.
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-run-build-fails-to-minify

@Klortho By the way I cannot express how grateful I am for this javascript port this opens so much UX/UI possibilities.
@qiaoyixuan
Copy link

My code: import { flextree } from 'd3-flextree/build/d3-flextree'
It works

piraxi added a commit to piraxi/d3-flextree that referenced this issue Sep 1, 2021
@piraxi
Added semicolon to unbreak linter
8580ca6 
Gets rid of this error: 

Klortho#10 151.5 npm ERR! /root/.npm/_cacache/tmp/git-clone-9c5e3dba/src/flextree.js
Klortho#10 151.5 npm ERR! 4:30 error Missing semicolon semi
Klortho#10 151.5 npm ERR!
Klortho#10 151.5 npm ERR! /root/.npm/_cacache/tmp/git-clone-9c5e3dba/src/test/api-tests.js
Klortho#10 151.5 npm ERR! 5:30 error Missing semicolon semi
Klortho#10 151.5 npm ERR!
Klortho#10 151.5 npm ERR! ✖ 2 problems (2 errors, 0 warnings)
This was referenced Sep 1, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pruxis @qiaoyixuan