Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with oscar & oscar-accounts ? #266

Closed
goutnet opened this issue Mar 5, 2019 · 2 comments
Closed

Integration with oscar & oscar-accounts ? #266

goutnet opened this issue Mar 5, 2019 · 2 comments

Comments

@goutnet
Copy link

goutnet commented Mar 5, 2019

Would it be possible to integrate with oscar-accounts for the accounts providing?

oscar-accounts provides a bit more features (and plays well with oscar as well)…

it could be either replace the Account model with the oscar-accounts or attach an oscar-account reference to it…

would you accept a pull request that would go in this direction?

@scaphilo
Copy link
Collaborator

It looks quite promising. I will need to think about your proposal in more detail. I will come back to you once I have a clearer picture.

@goutnet
Copy link
Author

goutnet commented Mar 10, 2019

I am waiting for an answer on their issue tracker before getting serious here:

django-oscar/django-oscar-accounts#64

Depending on their response, the way I saw it would be to use model inheritance to use Oscar-accounts as base class:

https://docs.djangoproject.com/en/2.1/topics/db/models/#model-inheritance

This would ensure koalix to be independent in the way it manages extra fields (ex: account documentation etc..)

@scaphilo scaphilo closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants