Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #1496

Closed
wants to merge 3 commits into from
Closed

Cleanup #1496

wants to merge 3 commits into from

Conversation

RblSb
Copy link
Contributor

@RblSb RblSb commented Aug 31, 2024

No description provided.

@RobDangerous
Copy link
Member

I'm very sorry but pull requests like this are very bad for me. It takes me less time to do a cleanup myself than to look through this. If you see specific cleanup needs, feel free to open some issues instead.

@RblSb
Copy link
Contributor Author

RblSb commented Aug 31, 2024

Is first and third commits are ok as separate PRs?

@RobDangerous
Copy link
Member

No. But a pull request for the feature you snuck in there would be ok (having an actual feature in a pull request called cleanup is really mean though).

@RblSb RblSb deleted the cleanup branch September 1, 2024 02:43
@RblSb
Copy link
Contributor Author

RblSb commented Sep 1, 2024

Sorry

@RobDangerous
Copy link
Member

No worries 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants