From d10513dfc0d47846fdb874b0a62ce9c8c7107644 Mon Sep 17 00:00:00 2001 From: Te Rauhina Jackson Date: Thu, 18 Jan 2018 20:41:33 +0000 Subject: [PATCH] Bug 20019: use Modern::Perl in misc perl scripts Test Plan: Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; services/itemrecorddisplay.pl suggestion/suggestion.pl tags/list.pl tags/review.pl virtualshelves/sendshelf.pl help.pl changelanguage.pl koha_perl_deps.pl debian/bd-to-depends debian/build-git-snapshot debian/list-deps docs/CAS/CASProxy/examples/koha_webservice.pl docs/CAS/CASProxy/examples/proxy_cas.pl docs/CAS/CASProxy/examples/proxy_cas_callback.pl docs/CAS/CASProxy/examples/proxy_cas_data.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- changelanguage.pl | 3 +-- debian/bd-to-depends | 3 +-- debian/build-git-snapshot | 3 +-- debian/list-deps | 3 +-- docs/CAS/CASProxy/examples/koha_webservice.pl | 3 +-- docs/CAS/CASProxy/examples/proxy_cas.pl | 3 +-- docs/CAS/CASProxy/examples/proxy_cas_callback.pl | 3 +-- docs/CAS/CASProxy/examples/proxy_cas_data.pl | 3 +-- help.pl | 3 +-- koha_perl_deps.pl | 3 +-- services/itemrecorddisplay.pl | 3 +-- suggestion/suggestion.pl | 3 +-- tags/list.pl | 3 +-- tags/review.pl | 3 +-- virtualshelves/sendshelf.pl | 3 +-- 15 files changed, 15 insertions(+), 30 deletions(-) diff --git a/changelanguage.pl b/changelanguage.pl index 360484c5fa5..3463c606455 100755 --- a/changelanguage.pl +++ b/changelanguage.pl @@ -15,8 +15,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use C4::Templates; use CGI qw ( -utf8 ); diff --git a/debian/bd-to-depends b/debian/bd-to-depends index cff8b244463..5bc755b9870 100755 --- a/debian/bd-to-depends +++ b/debian/bd-to-depends @@ -1,7 +1,6 @@ #!/usr/bin/perl -use strict; -use warnings; +use Modern::Perl; my @exclusions = ( 'debhelper', diff --git a/debian/build-git-snapshot b/debian/build-git-snapshot index 260816daac9..0ae21973550 100755 --- a/debian/build-git-snapshot +++ b/debian/build-git-snapshot @@ -21,8 +21,7 @@ # Srdjan Jankovic # Based on an sh version by Lars Wirzenius. -use strict; -use warnings; +use Modern::Perl; use Getopt::Long; use POSIX qw/strftime/; diff --git a/debian/list-deps b/debian/list-deps index cba49c61215..d599df855d1 100755 --- a/debian/list-deps +++ b/debian/list-deps @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . -use strict; -use warnings; +use Modern::Perl; use C4::Installer::PerlDependencies; diff --git a/docs/CAS/CASProxy/examples/koha_webservice.pl b/docs/CAS/CASProxy/examples/koha_webservice.pl index 1fc33ba6804..dbaa19ef2ea 100755 --- a/docs/CAS/CASProxy/examples/koha_webservice.pl +++ b/docs/CAS/CASProxy/examples/koha_webservice.pl @@ -32,8 +32,7 @@ =head1 CGI PARAMETERS =cut use utf8; -use strict; -use warnings; +use Modern::Perl; binmode(STDOUT, ":utf8"); use C4::Auth qw(check_api_auth); diff --git a/docs/CAS/CASProxy/examples/proxy_cas.pl b/docs/CAS/CASProxy/examples/proxy_cas.pl index 407892b4cf3..2db8d93f8de 100755 --- a/docs/CAS/CASProxy/examples/proxy_cas.pl +++ b/docs/CAS/CASProxy/examples/proxy_cas.pl @@ -28,8 +28,7 @@ =head1 DESCRIPTION =cut -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use Authen::CAS::Client; diff --git a/docs/CAS/CASProxy/examples/proxy_cas_callback.pl b/docs/CAS/CASProxy/examples/proxy_cas_callback.pl index 52e58e2990c..4ee46b5c2d0 100755 --- a/docs/CAS/CASProxy/examples/proxy_cas_callback.pl +++ b/docs/CAS/CASProxy/examples/proxy_cas_callback.pl @@ -25,8 +25,7 @@ =head1 DESCRIPTION =cut -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use Authen::CAS::Client; use Storable qw(nstore_fd); diff --git a/docs/CAS/CASProxy/examples/proxy_cas_data.pl b/docs/CAS/CASProxy/examples/proxy_cas_data.pl index ba4a138fcd4..a333f89faaf 100755 --- a/docs/CAS/CASProxy/examples/proxy_cas_data.pl +++ b/docs/CAS/CASProxy/examples/proxy_cas_data.pl @@ -30,8 +30,7 @@ =head1 CGI PARAMETERS =cut -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use Authen::CAS::Client; use Storable qw(fd_retrieve); diff --git a/help.pl b/help.pl index ad86a2da298..d549c231fe6 100755 --- a/help.pl +++ b/help.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use C4::Templates; use C4::Output; # use C4::Auth; diff --git a/koha_perl_deps.pl b/koha_perl_deps.pl index 9ca2a14cdb3..cf686324fad 100755 --- a/koha_perl_deps.pl +++ b/koha_perl_deps.pl @@ -9,8 +9,7 @@ use C4::Installer::PerlModules; -use strict; -use warnings; +use Modern::Perl; my $help = 0; my $missing = 0; diff --git a/services/itemrecorddisplay.pl b/services/itemrecorddisplay.pl index f4bb384e5aa..2c2832f955f 100755 --- a/services/itemrecorddisplay.pl +++ b/services/itemrecorddisplay.pl @@ -27,8 +27,7 @@ =head1 DESCRIPTION =cut -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl index 94e6eabd448..98fcca4914a 100755 --- a/suggestion/suggestion.pl +++ b/suggestion/suggestion.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; require Exporter; use CGI qw ( -utf8 ); use C4::Auth; # get_template_and_user diff --git a/tags/list.pl b/tags/list.pl index 9e90670637c..862327862f5 100755 --- a/tags/list.pl +++ b/tags/list.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use warnings; -use strict; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth qw(:DEFAULT check_cookie_auth); diff --git a/tags/review.pl b/tags/review.pl index f1484f1a87f..353e7419947 100755 --- a/tags/review.pl +++ b/tags/review.pl @@ -19,8 +19,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use warnings; -use strict; +use Modern::Perl; use Data::Dumper; use POSIX; use CGI qw ( -utf8 ); diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl index 9880efd680f..996c2f71cc8 100755 --- a/virtualshelves/sendshelf.pl +++ b/virtualshelves/sendshelf.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use Encode qw( encode );