Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use online config-schema.json instead of local #134

Open
bullmoose20 opened this issue Jul 13, 2024 · 9 comments
Open

Use online config-schema.json instead of local #134

bullmoose20 opened this issue Jul 13, 2024 · 9 comments
Milestone

Comments

@bullmoose20
Copy link
Collaborator

No description provided.

@bullmoose20
Copy link
Collaborator Author

The question is which url we should use in QuickStart instead of the local.

Master, Develop, Nightly?

@bullmoose20
Copy link
Collaborator Author

Or maybe there is a git action that always gets updated based on the Kometa master branch config-schema.json?

Clearly I am getting all mixed up and wondering how we handle QuickStart with the different branches of Kometa.

@chazlarson
Copy link
Contributor

I suppose there could be three branches of quickstart

@bullmoose20 bullmoose20 added this to the MVP milestone Jul 18, 2024
@bullmoose20
Copy link
Collaborator Author

I guess the issue is that if we want to follow what kometa does, then I am not sure how to implement this so that we keep the yaml validation in sync with any/all of the schema-config.json files in the three different branches

@bullmoose20
Copy link
Collaborator Author

@chazlarson and @YozoraXCII Any additional thoughts on how we do this?

Seems like we should also see if the current active schema and prototype have deviated from the ones used here in QS otherwise all of this testing might be in vain....

@chazlarson
Copy link
Contributor

How? Retrieve the schema from github rather than using the embedded copy.

Note, however, that the schema is typically incomplete.

@bullmoose20
Copy link
Collaborator Author

Is branch relevant or we should always go after latest? Or always nightly?

@chazlarson
Copy link
Contributor

It might matter, but since this tool is divorced from the schema, anyway, it would probably be simplest to add a drop-down to the final page for the user to choose, which branch to validate against defaulting to nightly. Default could be latest, doesn't really matter.

@bullmoose20
Copy link
Collaborator Author

It might matter, but since this tool is divorced from the schema, anyway, it would probably be simplest to add a drop-down to the final page for the user to choose, which branch to validate against defaulting to nightly. Default could be latest, doesn't really matter.

Ok... I am also pretty sure that QS is using a local copy of prototype.yml to pre-fill fields along the way and maybe in other capacities... I presume the same would apply there?

As far as techniques, pull them down locally and then read locally? Or try to read remote.... just wondering which would have better success... like overwriting local only when it makes sense and if the online source is unreachable, use local copies.

Also, since the last step already validates the yml in the same step, maybe moving that to the start page would be better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants