Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion]: Add Images to Overlay Preview #354

Closed
YozoraXCII opened this issue Feb 11, 2025 · 8 comments
Closed

[Suggestion]: Add Images to Overlay Preview #354

YozoraXCII opened this issue Feb 11, 2025 · 8 comments

Comments

@YozoraXCII
Copy link
Contributor

Currently, the user has to upload an image to see how the Overlays will look on it,

I propose we add some default options and also let the user select an image if they want to.

I've mocked this video up just to give you an idea of what I had in mind.

chrome_MqKzT4obVB.mp4
@bullmoose20
Copy link
Collaborator

Currently, the user has to upload an image to see how the Overlays will look on it,

I propose we add some default options and also let the user select an image if they want to.

I've mocked this video up just to give you an idea of what I had in mind.

chrome_MqKzT4obVB.mp4

Well... actually... if the user does nothing, and hits preview, the selected overlays will be put on a grey background.

Alternatively, if they upload their own image, it needs to respect the 1;1.5 ratio and be a png or jpg. It will get resized to 1000x1500 and then overlays selected will end up on the preview once you hit preview.

You can then delete the image with the red button. If preview is hit again, grey image is used.

If you upload a new image, and then hit preview if the right conditions are met, it will update.

If no overlays are selected, you get a toast message.

If you leave and return to page, and you have a custom image, toast message appears.

@YozoraXCII
Copy link
Contributor Author

Happy with what you've said, maybe a better idea is to also allow input of an image URL and it will then use that image directly rather than user having to download from the source and then upload to Quickstart?

@bullmoose20
Copy link
Collaborator

Linked to #352

@bullmoose20
Copy link
Collaborator

Funny because now that I viewed the video, I am thinking that we allow people to upload multiple custom photos images and they can choose the ones they want. They could delete the selected one as well.

So similar to the start page, where one button adds configs and the other can delete them one by one, we could do the same for base image uploads for the overlays preview. Hope I am making sense... lol

Thoughts?

@bullmoose20
Copy link
Collaborator

And offering a url option could be interesting as well... but may introduce some other issues like image size issues. We'd have to see.

@bullmoose20
Copy link
Collaborator

And as we chatted about... why not just have it displayed by default and as people toggle overlays, the poster preview is updated automatically.

@bullmoose20
Copy link
Collaborator

Adding a reminder that before embarking on this suggestion, we get all the requirements in one comment to ensure it's all implemented without any missing features

@bullmoose20
Copy link
Collaborator

The requirements:

  • Always show image whether custom or default grey
  • As overlays are selected, image shows it immediately
  • offer url option that would download the image and ensure it's of the correct dimensions
  • allow user to upload several different custom images making this similar to the start page
  • have drop-down scan directory and show the one you selected when you left the page be the one you get when you return
  • ability to delete images similar to the way we are able to delete config_name on start page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants