Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passwords tokens apikeys that are fully numeric causing yml validation issues #60

Open
bullmoose20 opened this issue Jun 2, 2024 · 4 comments
Milestone

Comments

@bullmoose20
Copy link
Collaborator

we need to address a password that is 100% numeric as the yaml validation thinks it is a number instead of a string. (Is this a schema.json fix or a wizard fix? I am not sure.

Originally posted by @bullmoose20 in #3 (comment)

@bullmoose20 bullmoose20 changed the title we need to address a password that is 100% numeric as the yaml validation thinks it is a number instead of a string. (Is this a schema.json fix or a wizard fix? I am not sure. passwords tokens apikeys that are fully numeric causing yml validation issues Jun 6, 2024
@bullmoose20 bullmoose20 added this to the MVP milestone Jul 18, 2024
@bullmoose20
Copy link
Collaborator Author

image

I put in a fake numeric only gotify api key forced the validate to true so that i could jumpto the final validation to share the error.

I suspect that the issue lies with the actual json schema?

@bullmoose20
Copy link
Collaborator Author

Or maybe we need to force fields being written as strings when they are all numeric?

@chazlarson
Copy link
Contributor

Yes, the value expects a string and that's a number.

@bullmoose20
Copy link
Collaborator Author

So the real question I think is whether this is a json-schema issue or a QuickStart issue.

Like will Kometa accept an all numeric username or password or secret in general or does it need to have single quotes around it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants