Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clippy): fix coins mod clippy warnings in wasm #2224

Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix(clippy): fix coins mod clippy warnings in wasm #2224

merged 2 commits into from
Sep 23, 2024

Conversation

borngraced
Copy link
Member

No description provided.

@borngraced borngraced self-assigned this Sep 16, 2024
@onur-ozkan
Copy link
Member

Looking at dev CI, there are no linting errors at all ? 🤔

@Alrighttt
Copy link
Member

Looking at dev CI, there are no linting errors at all ? 🤔

It's a fix for --all-features case.

@onur-ozkan
Copy link
Member

Looking at dev CI, there are no linting errors at all ? 🤔

It's a fix for --all-features case.

We should include this flag to CI then.

@borngraced
Copy link
Member Author

Looking at dev CI, there are no linting errors at all ? 🤔

It's a fix for --all-features case.

We should include this flag to CI then.

those clippy warnings can also show up when running

cargo test --target wasm32-unknown-unknown --package coins

--all-features is unusable now until SiaCode http_client code is synced

@shamardy shamardy mentioned this pull request Sep 20, 2024
Open
5 tasks
@shamardy
Copy link
Collaborator

--all-features is unusable now until SiaCode http_client code is synced

Added it to the SIA tracking issue #2201 (comment) c.c. @borngraced @Alrighttt

@shamardy shamardy changed the title fix(chore): coins mod WASM clippy warnings fix(clippy): coins mod WASM clippy warnings Sep 20, 2024
@shamardy shamardy changed the title fix(clippy): coins mod WASM clippy warnings fix(clippy): fix coins mod WASM clippy warnings Sep 20, 2024
@shamardy shamardy changed the title fix(clippy): fix coins mod WASM clippy warnings fix(clippy): fix coins mod clippy warnings in wasm Sep 20, 2024
@shamardy
* fix consts comments and move TAKER_PAYMENT_SPEND_SEARCH_INTERVAL …
4bded2e 
…to the only place it's used

* use not wasm attribute for solana macros
shamardy
shamardy approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once @onur-ozkan accepts this.

@shamardy shamardy merged commit cde7f36 into dev Sep 23, 2024
23 of 26 checks passed
@shamardy shamardy deleted the fix-coins-mod-wasm-clippy branch September 23, 2024 10:28
@mariocynicys
Copy link
Collaborator

those clippy warnings can also show up when running
cargo test --target wasm32-unknown-unknown --package coins
--all-features is unusable now until SiaCode http_client code is synced

I think we want to run these tests in CI. Looks like they are never ran.

dimxy added a commit that referenced this pull request Oct 4, 2024
@dimxy
Merge branch 'dev' into add-eth-access-list
6b569d7 
* dev:
  fix(orders): fix cancel order race condition using time-based cache (#2232)
  fix(legacy-swap): taker failed spend maker payment marked as failed (#2199)
  chore(adex-cli): deprecate adex-cli (#2234)
  feat(new-RPC): connection healthcheck implementation for peers  (#2194)
  fix(proxy-signature): add message lifetime overflows (#2233)
  feat(CI): handle remote files in a safer way (#2217)
  chore(doc): update issue address in README (#2227)
  fix(merge): remove duplicated db_root function (#2229)
  feat(wallets): add `get_wallet_names` rpc (#2202)
  chore(tests): don't use `.wait()` and use `block_on` instead (#2220)
  fix(native-rpc): remove escaped response body (#2219)
  fix(clippy): fix coins mod clippy warnings in wasm (#2224)
  feat(core): handling CTRL-C signal with graceful shutdown (#2213)
  docs(README): fix typos (#2212)
  remove the non-sense arguments (#2216)
  fix(db): stop creating the all-zeroes dir on KDF start (#2218)
dimxy added a commit that referenced this pull request Oct 4, 2024
@dimxy
Merge branch 'dev' into burn-dex-fee-for-non-kmd
c4b494a 
* dev:
  fix(orders): fix cancel order race condition using time-based cache (#2232)
  fix(legacy-swap): taker failed spend maker payment marked as failed (#2199)
  chore(adex-cli): deprecate adex-cli (#2234)
  feat(new-RPC): connection healthcheck implementation for peers  (#2194)
  fix(proxy-signature): add message lifetime overflows (#2233)
  feat(CI): handle remote files in a safer way (#2217)
  chore(doc): update issue address in README (#2227)
  fix(merge): remove duplicated db_root function (#2229)
  feat(wallets): add `get_wallet_names` rpc (#2202)
  chore(tests): don't use `.wait()` and use `block_on` instead (#2220)
  fix(native-rpc): remove escaped response body (#2219)
  fix(clippy): fix coins mod clippy warnings in wasm (#2224)
  feat(core): handling CTRL-C signal with graceful shutdown (#2213)
  docs(README): fix typos (#2212)
  remove the non-sense arguments (#2216)
  fix(db): stop creating the all-zeroes dir on KDF start (#2218)
dimxy added a commit that referenced this pull request Oct 17, 2024
@dimxy
Merge branch 'dev' into 1inch-classic-swap
116fb0c 
* dev:
  fix(cosmos): fix tx broadcasting error (#2238)
  chore(solana): remove solana implementation (#2239)
  chore(cli): remove leftover subcommands from help message (#2235)
  fix(orders): fix cancel order race condition using time-based cache (#2232)
  fix(legacy-swap): taker failed spend maker payment marked as failed (#2199)
  chore(adex-cli): deprecate adex-cli (#2234)
  feat(new-RPC): connection healthcheck implementation for peers  (#2194)
  fix(proxy-signature): add message lifetime overflows (#2233)
  feat(CI): handle remote files in a safer way (#2217)
  chore(doc): update issue address in README (#2227)
  fix(merge): remove duplicated db_root function (#2229)
  feat(wallets): add `get_wallet_names` rpc (#2202)
  chore(tests): don't use `.wait()` and use `block_on` instead (#2220)
  fix(native-rpc): remove escaped response body (#2219)
  fix(clippy): fix coins mod clippy warnings in wasm (#2224)
  feat(core): handling CTRL-C signal with graceful shutdown (#2213)
  docs(README): fix typos (#2212)
  remove the non-sense arguments (#2216)
  fix(db): stop creating the all-zeroes dir on KDF start (#2218)
@shamardy shamardy mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

@shamardy shamardy shamardy approved these changes

Assignees

@borngraced borngraced

Labels
under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@borngraced @onur-ozkan @Alrighttt @shamardy @mariocynicys