Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app version #2464

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Update app version #2464

merged 1 commit into from
Aug 22, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Aug 12, 2024

  • Confirm version string in settings is 0.8.0
  • Confirm VOTE2024 and all KIP voting chains have been removed

@smk762 smk762 requested a review from cipig August 12, 2024 07:57
@ShantanuSharma9873
Copy link
Collaborator

  • The Application Version has been successfully updated to 0.8.0 beta.
    image

  • But able to see the 'VOTE2024' at the Add Crypto. Also, the user is able to Enable the coin.
    image

AndrewDelaney
AndrewDelaney reviewed Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the Vote 2024 and KIP tokens are still present.
What has changed, though, is that the Vote 2024 asset is no longer added by default.

@smk762
Copy link
Collaborator Author

smk762 commented Aug 21, 2024

Both the Vote 2024 and KIP tokens are still present. What has changed, though, is that the Vote 2024 asset is no longer added by default.

They will appear until removed from https://github.com/KomodoPlatform/coins/blob/master/coins#L15642
I'll do the coins repo PR now for this

@smk762
Copy link
Collaborator Author

smk762 commented Aug 21, 2024

KomodoPlatform/coins#1131

cipig
cipig previously approved these changes Aug 21, 2024
View reviewed changes
@smk762 smk762 dismissed cipig’s stale review August 21, 2024 09:31

The merge-base changed after approval.

@smk762 smk762 changed the base branch from dev to dev-kdf August 22, 2024 13:12
@smk762 smk762 merged commit 31de753 into dev-kdf Aug 22, 2024
6 checks passed
@ca333 ca333 deleted the update/version branch October 23, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewDelaney AndrewDelaney AndrewDelaney left review comments

@cipig cipig cipig left review comments

@ShantanuSharma9873 ShantanuSharma9873 Awaiting requested review from ShantanuSharma9873

Assignees
No one assigned
Labels
awaiting review v0.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smk762 @ShantanuSharma9873 @AndrewDelaney @cipig