Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Remove delay in addrman.Select() and disable kmd seeds for asset chains #528

Closed
wants to merge 231 commits into from
Closed

[wip] Remove delay in addrman.Select() and disable kmd seeds for asset chains #528

wants to merge 231 commits into from

Conversation

dimxy
Copy link
Collaborator

@dimxy dimxy commented Jan 19, 2022

jmjatlanta and others added 30 commits June 1, 2021 06:44
@jmjatlanta
allow help text even during node warmup
0278350
@jmjatlanta
wrap test chain funcs into class
26843c9
@jmjatlanta
document chainparams
fd09a2d
@jmjatlanta
document KOMODO_CONNECTING
a305097
@jmjatlanta
more documentation
c3ebdba
@jmjatlanta
clean up of db open code
c3def98
@jmjatlanta
fix hang on shutdown
165bb0f
@jmjatlanta
documentation of notarisationdb
16a3254
@jmjatlanta
fix vector initialization lists
4d0063f
@jmjatlanta
Merge branch 'dev' into jmj_testutils
803f247
@jmjatlanta
Merge branch 'dev'
684c275
@jmjatlanta
Find calls to CChain that are not locked
7d7eabb
@jmjatlanta
Add locks of cs_main
0cba296
@jmjatlanta
Add AssertLockHeld to komodo_xxx
186661c 
Only those that use chainActive
@jmjatlanta
lock cs_main for TestBlockValidity
777ee02
@jmjatlanta
cs_main already locked
eb1f5fe
@jmjatlanta
Upgrade threadsafety.h to clang 13
5fb10cd
@jmjatlanta
Add annotations to CChain
b06e900
@jmjatlanta
fix clang warnings
93218bf
@jmjatlanta
Fix return value of is_STAKED
f8f5cee
@jmjatlanta
Fix haraka warnings
417f5c3
@jmjatlanta
fix ASSETCHAINS_ENDSUBSIDY
59fb0f9
@jmjatlanta
Fix more clang warnings
72b8022
@jmjatlanta
Increase heir test timeout
eb2a18c
@jmjatlanta
test komodo_notarysinit
a29cc24
@jmjatlanta
Addl testing komodo_notarysinit
0be5fca
@jmjatlanta
code cleanup
549db0b
@jmjatlanta
code cleanup and comments
4247895
@dimxy
wait for mining threads to stop
acd2b3b
@dimxy
convert staking array to vector (to correctly destroy members) and ma…
24f7d50 
…ke it thread_local
dimxy and others added 18 commits September 5, 2022 22:41
@dimxy
deleted py tests for kv service (removed)
8295377
@dimxy
return false if shutdown on import genesis, changed flag to function …
614bf7b 
…ShutdownRequested
@dimxy
allowed 'B' record in komodostate (never processed on reading though)
3824a2b
@dimxy
test notarisation: komodostate inited with a valid record
b6f4eea
@dimxy
info comment to long test
c83ea69
@dimxy
asserts added in test events to prevent bad mem access
1e9833d
@dimxy
remove 'virtual' def in CChain (no need anymore)
11779e9
@DeckerSU
undo / revert WITNESS_CACHE_SIZE related changes in CWallet
4c69fde 
1. _COINBASE_MATURITY+10 -> Params().CoinbaseMaturity()+10 substitution
suggested by author was bit incorrect, bcz _COINBASE_MATURITY == 100
at any time and Params().CoinbaseMaturity() depends on chain (for KMD
it's 100, for ACs it's 1) and assertion was wrong.
2. Introducing maxWitnessCacheSize CWallet member and fill it's default
value in c'tor made c'tors bit "ambiguously" and probably was
not a best idea.
@DeckerSU
configure libgmp on Linux with --with-pic=yes
b5cd131 
to avoid the following errors:

/usr/bin/ld: depends/x86_64-unknown-linux-gnu/lib/libgmp.a(invert_limb.o): warning: relocation against `__gmpn_invert_limb_table' in read-only section `.text'
/usr/bin/ld: warning: creating DT_TEXTREL in a PIE

when build with 11.2.0 (Ubuntu 22.04.1 LTS, etc.)
@DeckerSU
remove unused sources from repo (after jl777#559)
61c7d78
@DeckerSU
komodo_hardfork: avoid build error with CXXFLAGS='-g -O0'
1245cca 
    Issue: if we will try to build KomodoOcean with CXXFLAGS='-g -O0'
    we will get the following error during linkage:

    usr/bin/ld: libbitcoin_util.a(libbitcoin_util_a-util.o): in function `__static_initialization_and_destruction_0(int, int)':
    /home/decker/KomodoOcean/src/komodo_hardfork.h:19: undefined reference to `nStakedDecemberHardforkTimestamp'
    /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:19: undefined reference to `nS4Timestamp'
    /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:19: undefined reference to `nS5Timestamp'
    /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:19: undefined reference to `nS6Timestamp'
    /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:20: undefined reference to `nDecemberHardforkHeight'
    /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:20: undefined reference to `nS4HardforkHeight'
    /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:20: undefined reference to `nS5HardforkHeight'
    /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:20: undefined reference to `nS6HardforkHeight'

    So, we need to include komodo_hardfork.cpp into libbitcoin_util_a_SOURCES
    or delete include of komodo_hardfork.h from komodo_globals.h.
@DeckerSU
temporary disable test_events write_test
0ecfdf9 
because of error:

free(): double free detected in tcache 2
Aborted (core dumped)

TODO: fix this test.
@DeckerSU
get rid of LibTomCrypt derived hash implementations
5283ea9
@DeckerSU
report about komodostate parse error in messagebox, instead of console
65cad44
@DeckerSU
Pr559 add (#128)
fa2d133 
* fix function(s) invokations after inaccurate merge branches

* fix treating std as a label, name it's a variable of std::string type
@dimxy
more old marmara code removed
979abb1
@dimxy
hush net commission code removed
005df66
@dimxy
more pegs code removed
ba73fd3
@dimxy
Copy link
Collaborator Author

dimxy commented Sep 16, 2022

We maybe need to improve this PR.
I believe this is not good when the addrman object can be locked for minutes due to the delay in CAddrMan::Select_() and better be fixed.
But at the same time simply removing this delay leads to more frequent connection retries in ThreadOpenConnections() for small assets chains (where the nodes number < 16). Maybe we should add another delay between connection retries when peers number is small (like to move the delay from Select_() to ThreadOpenConnections() avoiding the addrman lock).

@dimxy dimxy force-pushed the addrman-delay-fix branch from abc21fa to 561a8af Compare October 14, 2022 11:48
@dimxy
Copy link
Collaborator Author

dimxy commented Oct 14, 2022

added param -noaddrmandelay

@tonymorony tonymorony marked this pull request as draft October 17, 2022 09:46
@tonymorony tonymorony changed the title Remove delay in addrman.Select() and disable kmd seeds for asset chains [wip] Remove delay in addrman.Select() and disable kmd seeds for asset chains Oct 17, 2022
@ca333
Copy link

ca333 commented Jan 29, 2024

archive

@ca333 ca333 closed this Jan 29, 2024
who-biz pushed a commit to who-biz/komodo that referenced this pull request Jul 29, 2024
@Asherda
Merge pull request KomodoPlatform#528 from Asherda/release-v1.0.11
8f1700f 
Release v1.0.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmjatlanta jmjatlanta jmjatlanta left review comments

@ca333 ca333 Awaiting requested review from ca333

@DeckerSU DeckerSU Awaiting requested review from DeckerSU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimxy @jmjatlanta @ca333 @DeckerSU