Add CreateTransaction endpoint #334
Open
+340
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmirAgassi
added
enhancement
4 tasks
juancwu
reviewed
Jan 6, 2025
Comment on lines
+13
to
+26
| var req CreateTransactionRequest | ||
| if err := c.Bind(&req); err != nil { | ||
| return v1_common.Fail(c, http.StatusBadRequest, "Invalid request body", err) | ||
| } | ||
|
|
||
| // Validate request | ||
| if err := c.Validate(&req); err != nil { | ||
| return v1_common.Fail(c, http.StatusBadRequest, "Validation failed", err) | ||
| } | ||
|
|
||
| // Validate project ID format | ||
| if _, err := uuid.Parse(req.ProjectID); err != nil { | ||
| return v1_common.Fail(c, http.StatusBadRequest, "Invalid project ID format", err) | ||
| } |
There was a problem hiding this comment.
Why are we not taking advantage of the validate tags and the request validator middleware?
There was a problem hiding this comment.
also we have helpers functions that simplify some of this logic
Comment on lines
+10
to
+24
| ProjectID string `json:"project_id" validate:"required,uuid4"` | ||
| TxHash string `json:"tx_hash" validate:"required"` | ||
| FromAddress string `json:"from_address" validate:"required"` | ||
| ToAddress string `json:"to_address" validate:"required"` | ||
| ValueAmount string `json:"value_amount" validate:"required,numeric"` | ||
| } | ||
|
|
||
| type TransactionResponse struct { | ||
| ID string `json:"id"` | ||
| ProjectID string `json:"project_id"` | ||
| CompanyID string `json:"company_id"` | ||
| TxHash string `json:"tx_hash"` | ||
| FromAddress string `json:"from_address"` | ||
| ToAddress string `json:"to_address"` | ||
| ValueAmount string `json:"value_amount"` |
There was a problem hiding this comment.
We can add validate tags here so that request objects can be validated using the request validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new endpoint for recording blockchain transactions associated with specific projects.
Linked Issues
Testing
backend/internal/tests/transactions_test.goChecklist
Before opening this PR, make sure the PR:
Additionally, make sure that: