From 68bfab30361e0131e09ea499a9bcb2fe5cf5d1f1 Mon Sep 17 00:00:00 2001 From: Rocky Fischer Date: Thu, 6 Feb 2025 15:22:59 -0500 Subject: [PATCH] fix(dashboard-renderer): attempt to split out entities-shared - Move `ajv` to a dev dependency, since it's only used in the sandbox [MA-3247] - Don't require `entities-shared` since it's a large package that's only useful within Konnect [MA-3246] - Host apps will need to provide a fallback, potentially via alias. --- packages/analytics/dashboard-renderer/package.json | 12 +++++++++--- pnpm-lock.yaml | 5 +++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/packages/analytics/dashboard-renderer/package.json b/packages/analytics/dashboard-renderer/package.json index 4d1aefff1e..61cc365e65 100644 --- a/packages/analytics/dashboard-renderer/package.json +++ b/packages/analytics/dashboard-renderer/package.json @@ -43,14 +43,15 @@ "@kong-ui-public/analytics-config-store": "workspace:^", "@kong-ui-public/analytics-metric-provider": "workspace:^", "@kong-ui-public/analytics-utilities": "workspace:^", + "@kong-ui-public/entities-shared": "workspace:^", "@kong-ui-public/i18n": "workspace:^", "@kong-ui-public/sandbox-layout": "workspace:^", "@kong/design-tokens": "1.17.2", "@kong/kongponents": "9.17.2", + "ajv": "^8.17.1", "pinia": ">= 2.1.7 < 3", "swrv": "^1.0.4", - "vue": "^3.5.12", - "ajv": "^8.17.1" + "vue": "^3.5.12" }, "repository": { "type": "git", @@ -74,14 +75,19 @@ "@kong-ui-public/analytics-config-store": "workspace:^", "@kong-ui-public/analytics-metric-provider": "workspace:^", "@kong-ui-public/analytics-utilities": "workspace:^", + "@kong-ui-public/entities-shared": "workspace:^", "@kong-ui-public/i18n": "workspace:^", "@kong/kongponents": "^9.14.16", "swrv": "^1.0.4", "vue": ">= 3.3.13 < 4" }, + "peerDependenciesMeta": { + "@kong-ui-public/entities-shared": { + "optional": true + } + }, "dependencies": { "@kong-ui-public/core": "workspace:^", - "@kong-ui-public/entities-shared": "workspace:^", "gridstack": "^11.3.0" } } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index b6ad3f758d..6f2643e0bf 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -382,6 +382,9 @@ importers: '@kong-ui-public/analytics-utilities': specifier: workspace:^ version: link:../analytics-utilities + '@kong-ui-public/entities-shared': + specifier: workspace:^ + version: link:../../entities/entities-shared '@kong-ui-public/i18n': specifier: workspace:^ version: link:../../core/i18n @@ -6597,6 +6600,7 @@ packages: lodash.isequal@4.5.0: resolution: {integrity: sha512-pDo3lu8Jhfjqls6GkMgpahsF9kCyayhgykjyLMNFTKWrpVdAQtYyB4muAMWozBB4ig/dtWAmsMxLEI8wuz+DYQ==} + deprecated: This package is deprecated. Use require('node:util').isDeepStrictEqual instead. lodash.ismatch@4.4.0: resolution: {integrity: sha512-fPMfXjGQEV9Xsq/8MTSgUf255gawYRbjwMyDbcvDhXgV7enSZA0hynz6vMPnpAb5iONEzBHBPsT+0zes5Z301g==} @@ -6624,6 +6628,7 @@ packages: lodash.pick@4.4.0: resolution: {integrity: sha512-hXt6Ul/5yWjfklSGvLQl8vM//l3FtyHZeuelpzK6mm99pNvN9yTDruNZPEJZD1oWrqo+izBmB7oUfWgcCX7s4Q==} + deprecated: This package is deprecated. Use destructuring assignment syntax instead. lodash.pickby@4.6.0: resolution: {integrity: sha512-AZV+GsS/6ckvPOVQPXSiFFacKvKB4kOQu6ynt9wz0F3LO4R9Ij4K1ddYsIytDpSgLz88JHd9P+oaLeej5/Sl7Q==}