Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug validating recipient balance when sending Substrate token #3713

Closed
2 tasks done
nampc1 opened this issue Sep 30, 2024 · 4 comments · Fixed by #3771
Closed
2 tasks done

Fix bug validating recipient balance when sending Substrate token #3713

nampc1 opened this issue Sep 30, 2024 · 4 comments · Fixed by #3771
Assignees
Milestone

Comments

@nampc1
Copy link

nampc1 commented Sep 30, 2024

Describe the task

  • Any token that requires a native token to keep alive will be blocked from sending

    • Actual: It is always forbidden to deposit tokens into an account with native token balance = 0
    • Expect: Only block sending tokens to accounts that require native token balance > 0
  • Update compare logic

    • Actual: Comparing with Transferable balance
    • Expect: Comparing with Total balance
@nampc1 nampc1 added this to the Milestone 8 milestone Sep 30, 2024
@nampc1
Copy link
Author

nampc1 commented Sep 30, 2024

#3473

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Dec 3, 2024

Version test: http://14.224.129.242:8900/s/Fdy8SA8cLcaHjTb

  • Error when transfer native token
    Actual: Show error

    Image

    Expect: Allow transfer

  • Error when transfer local token EVM
    Actual: Error when XCM local token EVM

    Image

    Expect: Allow transfer

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Dec 6, 2024

Version test:

  • Error when transfer MYTH(Polkadot asset hub)
    Actual: Show error

    Image

    Image

    Expect: Allow transfer

  • Unable to transfer TON
    Actual: show error
    Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants