Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve default enable config Show zero balance #1193

Open
ThaoNguyen998 opened this issue Dec 4, 2023 · 5 comments · May be fixed by #1257
Open

Improve default enable config Show zero balance #1193

ThaoNguyen998 opened this issue Dec 4, 2023 · 5 comments · May be fixed by #1257
Assignees
@Quangdm-cdm
Labels
important need-more-discussion
Milestone
Milestone 8

Comments

@ThaoNguyen998
Copy link

Describe the task
Improve default enable config Show zero balance
@ThaoNguyen998 ThaoNguyen998 added this to the Milestone 8 milestone Dec 4, 2023
@Quangdm-cdm Quangdm-cdm linked a pull request Dec 18, 2023 that will close this issue
Open
@Quangdm-cdm Quangdm-cdm linked a pull request Dec 18, 2023 that will close this issue
[issue-1193] Improve default enable config Show zero balance #1257
Open
@ThaoNguyen998
Copy link
Author

Version test: PR #1257 11:17 18/12/2023
Device test: IP 11

Validation passed.

Issue1193.MP4

@Sokol142196
Copy link

Sokol142196 commented Dec 25, 2023 •
edited by Quangdm-cdm
Loading

Version test: PR 1257 11:17 18/12/2023
Please check the issue:

  • Do not reset setting when reset account with reset all
    • Actual: Still show "Show zero balance" = OFF
    • Expect: Show "Show zero balance" = ON

Note for tester: Continue follow up performance before merge

@Sokol142196 Sokol142196 reopened this Dec 25, 2023
@ThaoNguyen998
Copy link
Author

Version test: PR #1257 26/12/2023
Device test: IP 11

Validation passed.
Follow up on MI 8 Lite

@nguyenduythuc
Copy link
Contributor

nguyenduythuc commented Jan 2, 2024 •
edited
Loading

@ThaoNguyen998 update following-up estimation time to close this issue

@hieudd hieudd modified the milestones: Milestone 7, Milestone 8 Jun 27, 2024
@nampc1
Copy link

nampc1 commented Jul 23, 2024

This can cause performance issue, not logical issue. It needs to be tested further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Quangdm-cdm Quangdm-cdm

Labels
important need-more-discussion
Projects
None yet
Milestone
Milestone 8
Development

Successfully merging a pull request may close this issue.

[issue-1193] Improve default enable config Show zero balance Koniverse/SubWallet-Mobile
6 participants
@hieudd @nguyenduythuc @nampc1 @Quangdm-cdm @ThaoNguyen998 @Sokol142196