Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the lost internet connection screen #199

Closed
3 of 4 tasks
sokol142 opened this issue Nov 7, 2022 · 9 comments · May be fixed by #984
Closed
3 of 4 tasks

Add the lost internet connection screen #199

sokol142 opened this issue Nov 7, 2022 · 9 comments · May be fixed by #984
Assignees
Milestone

Comments

@sokol142
Copy link

sokol142 commented Nov 7, 2022

Description

  • Add the lost connection screen

  • Show status to user know disconnected provider

  • With ListScreen:

  • Add No internet connection screen (no cache data)

  • With Transaction screen:

  • Add error message

  • show loading when no internet connection

  • make show/hide balance not depend on internet

@sokol142 sokol142 added this to the Milestone 4 milestone Nov 7, 2022
@sokol142 sokol142 changed the title Add the lost connection screen Add the lost internet connection screen Nov 9, 2022
@sokol142 sokol142 added w47-48 and removed w47-48 labels Nov 11, 2022
@hieudd hieudd modified the milestones: Milestone 4, Milestone 5 Dec 9, 2022
@hieudd hieudd modified the milestones: Milestone 5, Milestone 6 Apr 13, 2023
@Sokol142196 Sokol142196 modified the milestones: Milestone 6, Milestone 7 Jul 20, 2023
@Quangdm-cdm Quangdm-cdm linked a pull request Aug 16, 2023 that will close this issue
@ThaoNguyen998
Copy link

ThaoNguyen998 commented Aug 21, 2023

@Quangdm-cdm:

  • Use the toast modal (error type) with dismiss button when lost the internet connection
  • When the internet connection is connected -> show toast (success type) to notify to user

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Aug 24, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-209-983-merge-2023-08-24T11-01-20.ipa
Device test: IP 11

  • UI bug

Image

  • Show duplicate toast on Android

Image

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Aug 25, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-209-984-merge-2023-08-25T10-13-04.ipa
Device test: IP 11

  • Bug auto back to the previous screen when the network is reconnected
    Steps:
  1. Go to Send fund screen
  2. Perform transaction -> Go to Confirmation screen
  3. Disconnect network
  4. Re-connect network and observe the displayed screen
    Actual: https://bit.ly/46hG7ua
  • Bug overlapped modal in case re-connect
    Steps:
  1. Go to the confirmation Wallet connect screen
  2. Perform disconnect network and then re-connect network
  3. Observe the displayed screen

Actual: https://bit.ly/3PGf1WK

@Quangdm-cdm
Copy link
Collaborator

@sokol142 @ThaoNguyen998 this issue is related to background. So we need to improve background first

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Oct 10, 2023

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Oct 12, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-223-984-merge-2023-10-12T09-12-59.ipa
Device test: IP 11

@Quangdm-cdm Please re-check this issue

  • Error page when opening the app

Image

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Oct 16, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-224-984-merge-2023-10-13T09-14-17.ipa
Devices test: IP 11

  • Do not turn off Confirmation modal when re-connect internet in case Send NFT, sign with WalletConnect.

@Quangdm-cdm
Copy link
Collaborator

This issue need to implement from background @S2kael

@Sokol142196 Sokol142196 modified the milestones: Milestone 7, Milestone 8 Nov 9, 2023
@ThaoNguyen998
Copy link

Implement on issue #1171
-> Close issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants