-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type:text shouldn't show up in the KoralQuery serializer #196
Comments
It's interesting that this shows up in the KQ-Viewer. The |
Yes, it shouldn't show up in the serialization and it shouldn't be used in general. There should be no problem with that in the backend since Kalamar only sends the corpus query, not KoralQuery. |
Could you please check what request Kalamar actually sends to Kustvakt? I don't get any results sending the example direct API request using OAuth2 token and VPN, while Kalamar shows some results as reported in KorAP/Krill#86. |
Well - it is used by the corpus builder and it is used for indexing - so what do you mean by "it shouldn't be used in general"? Yes it is not helpful in a corpus request, but that is not happening. |
I am not sure to which query you are refering to. |
I suppose it shouldn't be used since it is not part of the KoralQuery doc and not supported in backend. Why is it used by corpus builder and indexing?
sorry for not being clear. I mean the query in KorAP/Krill#86 or |
The KoralQuery doc currently only covers the request and error reporting stuff - neither the indexing nor the response data format. Krill supports it for indexing (see That query doesn't show results to me. The request is: |
Thanks for your explanation. The query should show results with OAuth2 token and VPN since the Gingko corpus is restricted. |
But the VC is limited to CC-BY.* |
Sorry you are right. The request shouldn't be restricted to CC-BY.* For the following query
Kalamar would send the query below to Kustvakt, right?
This doesn't seem to be a problem from Kalamar and isn't related to type:text so I suppose we should discuss in KorAP/Krill#86 instead |
Yes, this is unrelated. Regarding this topic: I think the corpus assistant shouldn't alter the query serialized by the KoralQuery helper - but I think that's the only problem there is and it's a minor one, not affecting any functionality of the platform. |
While investigating KorAP/Krill#86, I found that
corpusTitle eq gingko
is serialized aswhilst
type:text
is not a type supported according to the KoralQuery doc and it is practically also not supported in Krill.The type is not added by any query rewrite as it is not added when sending a direct API request:
https://korap.ids-mannheim.de/instance/test/api/v1.0/search?q=ich&cq=availability+%3D+%2FCC-BY.*%2F+%26+docTitle+%3D+%22gingko%22&ql=poliqarp&cutoff=1&state=&pipe=
Could it be that Kalamar add the type?
The text was updated successfully, but these errors were encountered: