Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial/Documentation should always be opened in the first iframe #205

Open
Akron opened this issue Nov 7, 2023 · 0 comments
Open

Tutorial/Documentation should always be opened in the first iframe #205

Akron opened this issue Nov 7, 2023 · 0 comments
Assignees
Labels

Comments

@Akron
Copy link
Member

Akron commented Nov 7, 2023

When plugins are introduced with iframes, the wrong iframe may be considered in tutorial.js for retrieving the correct pathname.

https://github.com/KorAP/Kalamar/blob/master/dev/js/src/tutorial.js#L197

This can lead to weird CORS related errors.

One solution may be to open the tutorial always as a first iframe, or store the tutorial iframe in a global variable.

@Akron Akron added the bug label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants